<!DOCTYPE html><html><head><title></title><style type="text/css">#fastmail-quoted p.fastmail-quoted-MsoNormal,#fastmail-quoted p.fastmail-quoted-MsoNoSpacing{margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;}
p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div><br></div><div>On Thu, Apr 4, 2019, at 09:40, Rémi Denis-Courmont wrote:<br></div><blockquote type="cite" id="fastmail-quoted"><div>This patch is completely broken.<br></div></blockquote><div>This is a RFC, used to introduce a discussion on the window provider subject. OK I forgot to mention in the commit log, my bad.<br></div><div><br></div><blockquote type="cite" id="fastmail-quoted"><div><br></div><div>It does not work at all on Wayland.<br></div></blockquote><div><br></div><div>Why ?<br></div><div><br></div><blockquote type="cite" id="fastmail-quoted"><div>It barely works on X11, is not compatible with the existing semantics.<br></div><div>It includes stuff that makes no sense for an embedded video window.<br></div></blockquote><div><br></div><div>Which one ?<br></div><div><br></div><blockquote type="cite" id="fastmail-quoted"><div>It contradicts the design aspects agreed upon at the window and surface workshop.<br></div></blockquote><div><br></div><div>We just agreed on using callbacks, I don't remember any more details.<br></div><div><br></div><blockquote type="cite" id="fastmail-quoted"><div><br></div><div>I am not forcing you or anyone to implement this. If you are unwilling or unable to do it, then don't. But don't force me to review such a half-baked "RFC".<br></div></blockquote><div><br></div><div>I'm not forcing you to review anything, but could you just stop comparing work of other people as a joke ? This is always hurful. Such comment should never take place on VideoLAN mailing-list.<br></div><div><br></div><div>And yes, I'm not mastering the "vout window" very well... I mostly worked on the "vout display" side<br></div><div><br></div><div><br></div><blockquote type="cite" id="fastmail-quoted"><div><br></div><div><br></div><div><br></div><div class="fastmail-quoted-gmail_quote"><div>Le 4 avril 2019 10:29:24 GMT+03:00, Thomas Guillem <thomas@gllm.fr> a écrit :<br></div><blockquote style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="fastmail-quoted-gmail_quote"><div><br></div><div>On Thu, Apr 4, 2019, at 09:03, Rémi Denis-Courmont wrote:<br></div><blockquote id="fastmail-quoted-fastmail-quoted" type="cite"><div>Untested half-assed patch that does not worl, I will not review it.<br></div></blockquote><div><br></div><div>Hence the RFC. I just wanted to ask if I was going in the good direction.<br></div><div><br></div><div>This patch is missing the most important feature, the ability to create more than one "vout window" from the same opaque pointer:<br></div><div> - Add a new create_window callback that will return a different opaque pointer (window_opaque).<br></div><div> - Call every window ops with this opaque instead of the original one (or both).<br></div><div><br></div><blockquote id="fastmail-quoted-fastmail-quoted" type="cite"><div>-- <br></div><div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></blockquote></div><div><br></div><div>-- <br></div><div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></body></html>