<html><head></head><body>I haven't tested, but it seems odd to put comments between an ingroup stanza and its start marker.<br><br><div class="gmail_quote">Le 5 avril 2019 10:09:48 GMT+03:00, Alexandre Janniaux <ajanni@videolabs.io> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">Hi, thank you for the review.<br><br>Could you be more specific? AFAIR in the doxygen documentation, special<br>comment block preceding member group contains documentation for the <br>member<br>group, like preceding comment block before a function contains <br>documentation<br>for the function. I might misunderstand it but it seems to produce the <br>correct<br>result, even when detailed description is already defined somewhere <br>else, and<br>matches the examples on the doxygen documentation.<br><br>from doxygen documentation [1]:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Before the opening marker of a block a separate comment block may be <br>placed.<br>This block should contain the @name (or \name) command and is used to <br>specify<br>the header of the group. Optionally, the comment block may also contain <br>more<br>detailed information about the group.<br></blockquote><br>The fact that detailed information was inside the member group led to <br>having<br>input_item_t inherit the group documentation [2].<br><br>Do I misinterpret your review? There are maybe other issues \like file <br>documentation<br>but I don't really know this part.<br><br>[1]: <a href="http://www.doxygen.nl/manual/grouping.html#memgroup">http://www.doxygen.nl/manual/grouping.html#memgroup</a><br>[2]: <br><a href="https://www.videolan.org/developers/vlc/doc/doxygen/html/group__playlist.html#ga1656e9a2f1c25f8b7a0085c7af33f9c8">https://www.videolan.org/developers/vlc/doc/doxygen/html/group__playlist.html#ga1656e9a2f1c25f8b7a0085c7af33f9c8</a><br><br>On 2019-04-05 06:52, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">AFAIU how Doxygen works, this is incorrect.<br><br>Le 4 avril 2019 23:51:14 GMT+03:00, Alexandre Janniaux<br><ajanni@videolabs.io> a écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"><hr>include/vlc_playlist.h | 7 +++----<br>1 file changed, 3 insertions(+), 4 deletions(-)<br><br>diff --git a/include/vlc_playlist.h b/include/vlc_playlist.h<br>index 52edae9957..47561134fe 100644<br>--- a/include/vlc_playlist.h<br>+++ b/include/vlc_playlist.h<br>@@ -30,10 +30,7 @@ extern "C" {<br>/**<br> * \defgroup playlist playlist<br> * \ingroup playlist<br>- * @{<br>- */<br>-<br>-/**<br>+ *<br> * A VLC playlist contains a list of "playlist items".<br> *<br>* Each playlist item contains exactly one media (input item). In the<br>future,<br>@@ -102,6 +99,8 @@ extern "C" {<br>* may have changed the list. Therefore, vlc_playlist_Request*()<br>functions are<br>* exposed to resolve potential conflicts and apply the changes. The<br>actual<br> * changes applied are notified through the callbacks<br>+ *<br>+ * @{<br> */<br><br>/* forward declarations */<br>--<br>2.21.0<hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>