<html><head></head><body>Hi,<br><br>The TS demuxer has to detect and handle packet loss internally anyway because raw UDP and DVB accesses _cannot_ detect it. Ditto mid-stream reset. You are getting nowhere with adding a flag that you cannot rely on.<br><br>Meanwhile, RTP-TS is already handling stream reset and already uses a semi-ad-hoc interface to the TS demuxer. You don't need to mess with stream filters and vlc_data_t if you want a fully ad-hoc interface there to handle packet loss.<br><br><div class="gmail_quote">Le 25 avril 2019 05:03:21 GMT+03:00, Thomas Guillem <thomas@gllm.fr> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail"><br><br>On Wed, Apr 24, 2019, at 18:35, Denis Charmet wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Hi,<br><br>On 2019-04-24 15:57, Thomas Guillem wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;">I also 2 other issues with this RFC:<br> - Drop of flags in vlc_data_t: sadly, there will be no ways for<br>accesses to report a discontinuity. I know it is broken in VLC 3.0<br>since flags are lost in stream filters, but there are a lot of<br>requests to bring back the ability for accesses to notify a<br>discontinuity. We should fix it for 4.0 and therefore keep this flag.<br></blockquote>I thought about it when I was implementing it. And I don't know any <br>pure demux (short of TS) able to handle discontinuity. So you can flag <br>your stream, it will still be ignored. I don't see the point of keeping <br>that before demuxers can handle that.<br></blockquote><br>The ts demuxer can handle it. In the meantime, we hacked it by forging a ts packet that trigger a discontinuity, this is very ugly. <br>I don't like creating an access_demux for udp, rist, srt, rtp when we could use the ts demuxer and forward flags from the access. I would prefer to stick to the original plan that was access + demux, and fix the stream-filter to not loose this information once for good.<br><br>Maybe we could vote about it and/or hear Francois opinion. <br><br><br>> <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Regards,<br>-- <br>Denis Charmet - TypX<br>Le mauvais esprit est un art de vivre<hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>