<html><head></head><body>Well the assertion is doing its job, finding preexisting bugs.<br><br><div class="gmail_quote">Le 9 mai 2019 16:52:07 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">This commit make VLC crash with "--vout=none"<br><br>It assert in vout_Release() on "assert(!sys->window_active);"<br><br>After commit a1924dbd8bb3e3c146ef150191dcf8ffa0be0a59 "resource: <br>atomically return vout on failure (fixes #22284)" it's not an assert <br>anymore. It's a hard crash. vout_Request() is called with cfg->vout NULL.<br><br><br><br>On 2019-05-08 20:21, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">vlc | branch: master | Rémi Denis-Courmont <remi@remlab.net> | Wed May 8 18:54:01 2019 +0300| [587a5e2ac478b151848c06a55b1c9f7960f272de] | committer: Rémi Denis-Courmont<br><br>vout: remove dead code<br><br>If the vout was not stopped explicitly, vout_Close() will call<br>vout_Stop() anyway. Either way, the window is necessarily disabled when<br>the last reference to the vout is dropped.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"><a href="http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=587a5e2ac478b151848c06a55b1c9f7960f272de">http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=587a5e2ac478b151848c06a55b1c9f7960f272de</a><br></blockquote><hr> src/video_output/video_output.c | 3 +--<br> 1 file changed, 1 insertion(+), 2 deletions(-)<br><br>diff --git a/src/video_output/video_output.c b/src/video_output/video_output.c<br>index 27a269e9d9..ce7ca69b83 100644<br>--- a/src/video_output/video_output.c<br>+++ b/src/video_output/video_output.c<br>@@ -1715,8 +1715,7 @@ void vout_Release(vout_thread_t *vout)<br> vlc_mutex_destroy(&vout->p->spu_lock);<br> vlc_mutex_destroy(&vout->p->filter.lock);<br> <br>- if (sys->window_active)<br>- vout_window_Disable(sys->display_cfg.window);<br>+ assert(!sys->window_active);<br> vout_display_window_Delete(sys->display_cfg.window);<br> <br> vout_control_Clean(&vout->p->control);<hr>vlc-commits mailing list<br>vlc-commits@videolan.org<br><a href="https://mailman.videolan.org/listinfo/vlc-commits">https://mailman.videolan.org/listinfo/vlc-commits</a><br><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>