<div><br></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 13 May 2019 at 2:49 PM, Thomas Guillem <<a href="mailto:thomas@gllm.fr">thomas@gllm.fr</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><u></u><div></div><div><div><br></div><div><br></div><div>On Sat, May 11, 2019, at 15:56, Roland Bewick wrote:<br></div><blockquote type="cite" id="m_-7295863533725393274qt"><p><br></p><div class="m_-7295863533725393274qt-moz-cite-prefix">On 11/05/2019 6:21 PM, Jean-Baptiste
Kempf wrote:<br></div><blockquote type="cite"><div><br></div><div><br></div><div>On Sat, 11 May 2019, at 13:15, Roland Bewick wrote:<br></div><blockquote id="m_-7295863533725393274qt-qt" type="cite"><div><div>On Sat, 11 May 2019 at 4:17 PM, Rémi Denis-Courmont <<a href="mailto:remi@remlab.net" target="_blank">remi@remlab.net</a>>
wrote:<br></div><blockquote class="m_-7295863533725393274qt-qt-gmail_quote" style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(204,204,204);border-left-style:solid;border-left-width:1px;padding-left:1ex"><div><div>Hi,<br></div><div><br></div><div>While it likely makes sense at the level of UI
widgets and user interactions, it seems a bit out of
place, standing alone, at the player API level.<br></div><div><br></div><div>In particular, I doubt that enabling multiple tracks
mode in Qt should interfere with the track selection of,
say, the HTTP remote control.<br></div><div><br></div><div>IMO, the API should just take the list of active
tracks, whether it be empty, a singleton, or larger.<br></div></div></blockquote><div dir="auto"><br></div><div dir="auto">Hi, Remi,<br></div><div dir="auto"><br></div><div dir="auto">I designed the changes so that none of the
current consumers of the API will be impacted.<br></div><div dir="auto"><br></div><div dir="auto">Enabling dual subtitles will not affect the
others (like the remote control or lua scripts), because
there is another requirement: to temporarily enable
multitrack selection using the new call I added. The UI and
hotkeys use this but none of the others do.<br></div><div dir="auto"><br></div><div dir="auto">I do agree however that your suggestion is
more fitting (but require a bit more logic from each
consumer that supports selecting multiple tracks)<br></div></div></blockquote><div><br></div><div>Make the API simple to maintain, for the core. UI will adapt.<br></div><div><br></div><div id="m_-7295863533725393274qt-sig60240713"><div class="m_-7295863533725393274qt-signature">--<br></div><div class="m_-7295863533725393274qt-signature">Jean-Baptiste Kempf - President<br></div><div class="m_-7295863533725393274qt-signature">+33 672 704 734<br></div><div class="m_-7295863533725393274qt-signature"> <br></div><div class="m_-7295863533725393274qt-signature"><br></div></div><div><br></div><div><br></div><pre class="m_-7295863533725393274qt-moz-quote-pre">_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a href="https://mailman.videolan.org/listinfo/vlc-devel" class="m_-7295863533725393274qt-moz-txt-link-freetext" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br></pre></blockquote><p></p><div>Unfortunately it isn't just the SelectTrack function, but
SelectNextTrack and SelectPrevTrack too.<br></div><div> <br></div><div> I feel like making the consumer pass a list of already selected
tracks *plus* the new track to select is not right.<br></div><div> <br></div><div> I agree the api should be simple but it should also be simple to
use. Will this change make the core less complex?<br></div><p></p><p>What I've done isn't so good, yes. But I don't think Rémi's idea
is right either. We're basically searching for tracks and then
excluding the selected ones so that they don't get selected again.<br></p><p></p><div>Potential alternative option: <br></div><div> - Pass an extra parameter into the existing SelectTrack function -
selection type (Single / multiple).<br></div><div> - For SelectNextTrack/SelectPrevTrack functions I would need to
pass the "spu id" (1=primary, 2=secondary, 3=tertiary sub track)<br></div><p></p></blockquote><div><br></div></div><div><div>Next/Prev should be disabled if there are multpiple tracks selected. Indeed, this function is mostly used from a keyboard shortcut and there is no way to circle next/prev for a specified id from a keyboard.</div></div></blockquote><div dir="auto"><br></div><div dir="auto">See my addition to cycling the secondary subtitle track using the keyboard.</div><div dir="auto"><br></div><div dir="auto">The secondary sub track can be controlled in the same way as the primary one using the new hotkey I added.</div><div dir="auto"><br></div><div dir="auto">Roland</div></div></div>