<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div>The new way to select multiple tracks should be more generic since it could possibly work for video and audio (in the future).<br></div><div><br></div><div>The player API is new and was not yet published, we can modify it easily.<br></div><div><br></div><div>We could just add a "bool multiple" to vlc_player_SelectTrack(); and specify in the documentation that multiple work only for Video and for 2 subtitles.<br></div><div><br></div><div>Or we can find a new function, like vlc_player_SelectTrackMultiple().<br></div><div><br></div><div>On Tue, May 14, 2019, at 19:42, Roland Bewick wrote:<br></div><blockquote type="cite" id="qt"><div><br></div><div><div><br></div><div class="qt-gmail_quote"><div class="qt-gmail_attr" dir="ltr">On Wed, 15 May 2019 at 12:02 AM, Rémi Denis-Courmont <<a href="mailto:remi@remlab.net">remi@remlab.net</a>> wrote:<br></div><blockquote style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="qt-gmail_quote"><div>Le tiistaina 14. toukokuuta 2019, 12.40.00 EEST Roland Bewick a écrit :<br></div><div> > ---<br></div><div> > include/vlc_player.h | 13 +++++++++++++<br></div><div> > src/input/es_out.c | 47<br></div><div> > ++++++++++++++++++++++++++++++++++++++++++++-- src/input/es_out.h |<br></div><div> > 5 ++++-<br></div><div> > src/input/input.c | 5 +++++<br></div><div> > src/input/input_internal.h | 1 +<br></div><div> > src/input/player.c | 11 +++++++++++<br></div><div> > src/libvlccore.sym | 1 +<br></div><div> > 7 files changed, 80 insertions(+), 3 deletions(-)<br></div><div> > <br></div><div> > diff --git a/include/vlc_player.h b/include/vlc_player.h<br></div><div> > index 1aa5f8e687..077b3883ad 100644<br></div><div> > --- a/include/vlc_player.h<br></div><div> > +++ b/include/vlc_player.h<br></div><div> > @@ -2428,6 +2428,19 @@ VLC_API unsigned<br></div><div> > vlc_player_GetSubtitleTextScale(vlc_player_t *player);<br></div><div> > <br></div><div> > /**<br></div><div> > + * Allow secondary subtitle track(s) to be selected when<br></div><div> > + * the primary subtitle track is already selected.<br></div><div> > + *<br></div><div> > + * @note This must be returned to false immediately after<br></div><div> > + * selection of the subtitle.<br></div><div> <br></div><div> No - that won't work because you cannot assume atomicity of the following <br></div><div> operations on the ES output , at least not with the following code.<br></div></blockquote><div dir="auto"><br></div><div dir="auto">You’re correct, but the possibility of unwanted ES selection occuring in actual use is negligible.<br></div><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto"><br></div><blockquote style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="qt-gmail_quote"><div><br></div><div><br></div><div><br></div><div>--<br></div><div> Реми Дёни-Курмон<br></div><div> <a rel="noreferrer" href="http://www.remlab.net/">http://www.remlab.net/</a><br></div><div> <br></div><div> <br></div><div> <br></div><div> _______________________________________________<br></div><div> vlc-devel mailing list<br></div><div> To unsubscribe or modify your subscription options:<br></div><div> <a rel="noreferrer" href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote></div></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></body></html>