<html><head></head><body>Why are the flags cherry-picked here but systematic in contribs?<br><br><div class="gmail_quote">Le 16 mai 2019 11:03:24 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">This will only be enabled when building windows targets and will only work when<br>compiling with Clang.<hr> bin/Makefile.am | 4 ++++<br> compat/Makefile.am | 3 +++<br> configure.ac | 13 +++++++++++++<br> lib/Makefile.am | 4 ++++<br> modules/common.am | 3 +++<br> src/Makefile.am | 4 ++++<br> 6 files changed, 31 insertions(+)<br><br>diff --git a/bin/Makefile.am b/bin/Makefile.am<br>index 0bfa668806..d3e9144efe 100644<br>--- a/bin/Makefile.am<br>+++ b/bin/Makefile.am<br>@@ -25,6 +25,7 @@ endif<br> #<br> vlc_LDADD = ../lib/libvlc.la<br> vlc_CPPFLAGS = $(AM_CPPFLAGS)<br>+vlc_CFLAGS = $(AM_CFLAGS)<br> if !HAVE_WIN32<br> vlc_SOURCES = vlc.c override.c<br> vlc_LDADD += $(LIBDL)<br>@@ -32,6 +33,9 @@ else<br> vlc_SOURCES = winvlc.c<br> vlc_DEPENDENCIES = vlc_win32_rc.$(OBJEXT)<br> vlc_LDFLAGS = -mwindows -Wc,-static<br>+if HAVE_PDB<br>+vlc_LDFLAGS += -Wl,-pdb,vlc.pdb<br>+endif<br> vlc_LDADD += vlc_win32_rc.$(OBJEXT)<br> libbreakpad_wrapper_la_SOURCES = breakpad.cpp<br> libbreakpad_wrapper_la_LIBADD = $(BREAKPAD_LIBS)<br>diff --git a/compat/Makefile.am b/compat/Makefile.am<br>index d709d565c5..785721c0aa 100644<br>--- a/compat/Makefile.am<br>+++ b/compat/Makefile.am<br>@@ -2,6 +2,9 @@ pkglib_LTLIBRARIES = libcompat.la<br> libcompat_la_SOURCES = dummy.c<br> libcompat_la_LIBADD = $(LTLIBOBJS) $(LIBRT) $(LIBM)<br> libcompat_la_LDFLAGS = -no-undefined -static<br>+if HAVE_PDB<br>+libcompat_la_LDFLAGS += -Wl,-pdb,libcompat.pdb<br>+endif<br> <br> BUILT_SOURCES = dummy.c<br> CLEANFILES = dummy.c<br>diff --git a/configure.ac b/configure.ac<br>index a08be619ac..ecb51a4cd6 100644<br>--- a/configure.ac<br>+++ b/configure.ac<br>@@ -349,6 +349,18 @@ AS_IF([test "${SYS}" = "mingw32"],[<br> ])<br> AC_DEFINE_UNQUOTED(VLC_WINSTORE_APP, ${vlc_winstore_app}, [Define to 1 if you want to build for Windows Store apps])<br> <br>+vlc_build_pdb=0<br>+AC_ARG_ENABLE([pdb],<br>+ AS_HELP_STRING([--enable-pdb],<br>+ [Build PDB files for windows targets (default off)]))<br>+AS_IF([test "${SYS}" = "mingw32"],[<br>+ AS_IF([test "${enable_pdb}" = "yes"], [<br>+ vlc_build_pdb=1<br>+ AX_APPEND_FLAG([-g -gcodeview],[CFLAGS])<br>+ AX_APPEND_FLAG([-g -gcodeview],[CXXFLAGS])<br>+ ],[])<br>+])<br>+<br> AM_CONDITIONAL([HAVE_LINUX], [test "${SYS}" = "linux"])<br> AM_CONDITIONAL([HAVE_OS2], [test "${SYS}" = "os2"])<br> <br>@@ -364,6 +376,7 @@ AM_CONDITIONAL([HAVE_WIN32], [test "${SYS}" = "mingw32"])<br> AM_CONDITIONAL([HAVE_WIN64], [test "${HAVE_WIN64}" = "1"]) dnl Only used for the packaging<br> AM_CONDITIONAL([HAVE_WINSTORE], [test "$vlc_winstore_app" = "1"])<br> AM_CONDITIONAL([HAVE_WIN32_DESKTOP], [test "${SYS}" = "mingw32" -a "$vlc_winstore_app" = "0"])<br>+AM_CONDITIONAL([HAVE_PDB], [test "$vlc_build_pdb" = "1"])<br> <br> dnl Use nasm/yasm only on x86<br> AC_CHECK_PROGS(X86ASM, [nasm yasm])<br>diff --git a/lib/Makefile.am b/lib/Makefile.am<br>index 8dbbaf9d2a..d7ce6ebe38 100644<br>--- a/lib/Makefile.am<br>+++ b/lib/Makefile.am<br>@@ -63,10 +63,14 @@ libvlc_la_LDFLAGS = \<br> -version-info 12:0:0 \<br> -export-symbols $(srcdir)/libvlc.sym<br> libvlc_la_DEPENDENCIES = libvlc.sym<br>+libvlc_la_CFLAGS = $(AM_CFLAGS)<br> if HAVE_WIN32<br> libvlc_la_DEPENDENCIES += ../src/libvlc_win32_rc.$(OBJEXT)<br> libvlc_la_LDFLAGS += -Wl,../src/libvlc_win32_rc.$(OBJEXT) -avoid-version -Wc,-static<br> endif<br>+if HAVE_PDB<br>+libvlc_la_LDFLAGS += -Wl,-pdb,libvlc.pdb<br>+endif<br> if HAVE_OS2<br> libvlc_la_LDFLAGS += -avoid-version<br> endif<br>diff --git a/modules/common.am b/modules/common.am<br>index b991f6ce2f..d5be9f3d82 100644<br>--- a/modules/common.am<br>+++ b/modules/common.am<br>@@ -36,6 +36,9 @@ AM_LDFLAGS = \<br> if HAVE_WIN32<br> AM_LDFLAGS += $(top_builddir)/modules/module.rc.lo -Wc,-static<br> endif<br>+if HAVE_PDB<br>+AM_LDFLAGS += -Wl,-pdb,lib$(MODULE_STRING)_plugin.pdb<br>+endif<br> AM_YFLAGS = -d -Wno-yacc<br> <br> SUFFIXES = .l .y .asm<br>diff --git a/src/Makefile.am b/src/Makefile.am<br>index bc826dfefe..f59ad45381 100644<br>--- a/src/Makefile.am<br>+++ b/src/Makefile.am<br>@@ -508,10 +508,14 @@ libvlccore_la_LDFLAGS = \<br> -export-symbols $(srcdir)/libvlccore.sym \<br> -version-info 9:0:0<br> libvlccore_la_DEPENDENCIES = libvlccore.sym<br>+libvlccore_la_CFLAGS = $(AM_CFLAGS)<br> if HAVE_WIN32<br> libvlccore_la_DEPENDENCIES += libvlc_win32_rc.$(OBJEXT)<br> libvlccore_la_LDFLAGS += -Wl,libvlc_win32_rc.$(OBJEXT) -avoid-version -Wc,-static $(LIBCOM)<br> endif<br>+if HAVE_PDB<br>+libvlccore_la_LDFLAGS += -Wl,-pdb,libvlccore.pdb<br>+endif<br> if HAVE_OS2<br> libvlccore_la_LDFLAGS += -avoid-version<br> endif</pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>