<html><head></head><body>Hi,<br><br>I would drop this for now. IMO we should support splitting debug symbols from binaries but that's a lot of work.<br><br><div class="gmail_quote">Le 20 mai 2019 15:28:13 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 2019-05-20 14:12, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Hi,<br><br>Typically --enable-debug is to generate self-debugging code such as <br>asserts, not debug symbols. Symbols are generated by default and <br>stripped (or not) at install.<br></blockquote><br>How about --disable-symbols ?<br><br>I can also entirely drop this patch if we assume we always build with <br>symbols and strip in the end.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Le 20 mai 2019 12:23:55 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<br><br> By default debug information is generated<hr> contrib/bootstrap | 6 ++++++<br> contrib/src/main.mak | 9 +++++++--<br> 2 files changed, 13 insertions(+), 2 deletions(-)<br><br> diff --git a/contrib/bootstrap b/contrib/bootstrap<br> index 96c59f71fa..547fe3afd6 100755<br> --- a/contrib/bootstrap<br> +++ b/contrib/bootstrap<br> @@ -35,6 +35,7 @@ usage()<br> echo " --enable-ad-clauses configure to build packages with advertising clauses"<br> echo " (USE AT YOUR OWN LEGAL RISKS)"<br> echo " --disable-optim disable optimization in libraries"<br> + echo " --disable-debug disable generating debug information"<br> }<br> <br> BUILD=<br> @@ -49,6 +50,7 @@ GPL="1"<br> GNUV3="1"<br> AD_CLAUSES=<br> WITH_OPTIMIZATION="1"<br> +HAVE_DEBUG="1"<br> <br> if test ! -f "../../contrib/src/main.mak"<br> then<br> @@ -84,6 +86,9 @@ do<br> --disable-optim)<br> WITH_OPTIMIZATION=<br> ;;<br> + --disable-debug)<br> + HAVE_DEBUG=<br> + ;;<br> --enable-small)<br> ENABLE_SMALL=1<br> ;;<br> @@ -265,6 +270,7 @@ test -z "$GPL" || add_make_enabled "GPL"<br> test -z "$GNUV3" || add_make_enabled "GNUV3"<br> test -z "$AD_CLAUSES" || add_make_enabled "AD_CLAUSES"<br> test -z "$WITH_OPTIMIZATION" || add_make_enabled "WITH_OPTIMIZATION"<br> +test -z "$HAVE_DEBUG" || add_make_enabled "HAVE_DEBUG"<br> test "`uname -o 2>/dev/null`" != "Msys" || add_make "CMAKE_GENERATOR := -G \"MSYS Makefiles\""<br> <br> #<br> diff --git a/contrib/src/main.mak b/contrib/src/main.mak<br> index 30a5e1f03a..3868ea8fac 100644<br> --- a/contrib/src/main.mak<br> +++ b/contrib/src/main.mak<br> @@ -185,10 +185,15 @@ cppcheck = $(shell $(CC) $(CFLAGS) -E -dM - < /dev/null | grep -E $(1))<br> <br> EXTRA_CFLAGS += -I$(PREFIX)/include<br> CPPFLAGS := $(CPPFLAGS) $(EXTRA_CFLAGS)<br> -CFLAGS := $(CFLAGS) $(EXTRA_CFLAGS) -g<br> -CXXFLAGS := $(CXXFLAGS) $(EXTRA_CFLAGS) $(EXTRA_CXXFLAGS) -g<br> +CFLAGS := $(CFLAGS) $(EXTRA_CFLAGS)<br> +CXXFLAGS := $(CXXFLAGS) $(EXTRA_CFLAGS) $(EXTRA_CXXFLAGS)<br> LDFLAGS := $(LDFLAGS) -L$(PREFIX)/lib $(EXTRA_LDFLAGS)<br> <br> +ifdef HAVE_DEBUG<br> +CFLAGS := $(CFLAGS) -g<br> +CXXFLAGS := $(CXXFLAGS) -g<br> +endif<br> +<br> ifndef WITH_OPTIMIZATION<br> CFLAGS := $(CFLAGS) -O0<br> CXXFLAGS := $(CXXFLAGS) -O0<br><br><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser <br>ma brièveté.<hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>