<html><head></head><body>Hi,<br><br>Are you sure that the enum is frozen in adamantium? Changing an enum typedef is an ABI break, in general.<br><br><div class="gmail_quote">Le 27 mai 2019 14:18:05 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">No need to use an unsigned if we have a clean enum.<br>We already use a lot enums in all the libvlc API's.<hr> include/vlc/libvlc_media_player.h | 16 ++++++++--------<br> 1 file changed, 8 insertions(+), 8 deletions(-)<br><br>diff --git a/include/vlc/libvlc_media_player.h b/include/vlc/libvlc_media_player.h<br>index 7706765beb..e34fbccf5f 100644<br>--- a/include/vlc/libvlc_media_player.h<br>+++ b/include/vlc/libvlc_media_player.h<br>@@ -1756,19 +1756,19 @@ LIBVLC_API void libvlc_video_set_deinterlace( libvlc_media_player_t *p_mi,<br> * Get an integer marquee option value<br> *<br> * \param p_mi libvlc media player<br>- * \param option marq option to get \see libvlc_video_marquee_int_option_t<br>+ * \param option marq option to get<br> */<br> LIBVLC_API int libvlc_video_get_marquee_int( libvlc_media_player_t *p_mi,<br>- unsigned option );<br>+ libvlc_video_marquee_option_t option );<br> <br> /**<br> * Get a string marquee option value<br> *<br> * \param p_mi libvlc media player<br>- * \param option marq option to get \see libvlc_video_marquee_string_option_t<br>+ * \param option marq option to get<br> */<br> LIBVLC_API char *libvlc_video_get_marquee_string( libvlc_media_player_t *p_mi,<br>- unsigned option );<br>+ libvlc_video_marquee_option_t option );<br> <br> /**<br> * Enable, disable or set an integer marquee option<br>@@ -1777,21 +1777,21 @@ LIBVLC_API char *libvlc_video_get_marquee_string( libvlc_media_player_t *p_mi,<br> * or disabling (arg 0) the marq filter.<br> *<br> * \param p_mi libvlc media player<br>- * \param option marq option to set \see libvlc_video_marquee_int_option_t<br>+ * \param option marq option to set<br> * \param i_val marq option value<br> */<br> LIBVLC_API void libvlc_video_set_marquee_int( libvlc_media_player_t *p_mi,<br>- unsigned option, int i_val );<br>+ libvlc_video_marquee_option_t option, int i_val );<br> <br> /**<br> * Set a marquee string option<br> *<br> * \param p_mi libvlc media player<br>- * \param option marq option to set \see libvlc_video_marquee_string_option_t<br>+ * \param option marq option to set<br> * \param psz_text marq option value<br> */<br> LIBVLC_API void libvlc_video_set_marquee_string( libvlc_media_player_t *p_mi,<br>- unsigned option, const char *psz_text );<br>+ libvlc_video_marquee_option_t option, const char *psz_text );<br> <br> /** option values for libvlc_video_{get,set}_logo_{int,string} */<br> enum libvlc_video_logo_option_t {</pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>