<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 28/05/2019 5:09 PM, Rémi
      Denis-Courmont wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:85F4C2A4-9AA6-4FD6-9BB7-9F74C9C072DB@remlab.net">
      <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
      I'm trying to keep things simple by not leaking stuff across UIs
      especially when some won't handle it.<br>
      <br>
      Since separate hotkeys are already there, I don't see why you need
      a flag at all as far as hotkeys are concerned.<br>
      <br>
      <div class="gmail_quote">Le 28 mai 2019 12:23:58 GMT+03:00, Roland
        Bewick <a class="moz-txt-link-rfc2396E" href="mailto:roland.bewick@gmail.com"><roland.bewick@gmail.com></a> a écrit :</div>
    </blockquote>
    <p>Yes. There is no problem in that scenario. But, If you select
      dual subtitles in the hotkeys first, dual subtitles won't be
      enabled in the QT GUI.</p>
    <p>(Two tracks will be selected in the menu while the "Enable Dual
      Subtitles" option is unselected).</p>
    <p>Roland<br>
    </p>
    <blockquote type="cite"
      cite="mid:85F4C2A4-9AA6-4FD6-9BB7-9F74C9C072DB@remlab.net">
      <div class="gmail_quote">
        <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
          0.8ex; border-left: 1px solid rgb(204, 204, 204);
          padding-left: 1ex;">
          <p><br>
          </p>
          <div class="moz-cite-prefix">On 28/05/2019 1:38 PM, Rémi
            Denis-Courmont wrote:<br>
          </div>
          <blockquote type="cite"
            cite="mid:5456F6F1-DD27-4716-8026-2F88DC54B721@remlab.net">
            <meta http-equiv="Content-Type" content="text/html;
              charset=UTF-8">
            Hi,<br>
            <br>
            The whole point of adding a call to atomically select all
            SPU ES is that we don't need to keep UIs in sync.<br>
            <br>
            Keeping that stuff synched would break existing UIs that
            don't support multiple SPU, which are not going to disappear
            overnight.<br>
            <br>
            And it would require some code-complex and
            user-uninteligible transaction model... Or what will happen
            if a UI asks to enable two SPU's after another UI disabled
            multiple SPU's??<br>
            <br>
            <div class="gmail_quote">Le 28 mai 2019 08:45:41 GMT+03:00,
              Roland Bewick <a class="moz-txt-link-rfc2396E"
                href="mailto:roland.bewick@gmail.com"
                moz-do-not-send="true"><roland.bewick@gmail.com></a>
              a écrit :</div>
          </blockquote>
          <p>Hi, please refer to Jean-Baptiste's requirement: "If you
            enable dual-spu in Qt, it must work in the hotkeys.",<br>
          </p>
          <p>As to the existing UIs - They don't use the new
            vlc_player_SelectTrackList function.</p>
          <p>I feel like you're making this over-complicated.<br>
          </p>
          <p><br>
          </p>
          <p><br>
          </p>
          <blockquote type="cite"
            cite="mid:5456F6F1-DD27-4716-8026-2F88DC54B721@remlab.net">
            <div class="gmail_quote">
              <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
                0.8ex; border-left: 1px solid rgb(204, 204, 204);
                padding-left: 1ex;">
                <p><br>
                </p>
                <div class="moz-cite-prefix">On 28/05/2019 12:12 PM,
                  Rémi Denis-Courmont wrote:<br>
                </div>
                <blockquote type="cite"
                  cite="mid:86A2E34C-22FB-47F8-A627-F87E264D660C@remlab.net">
                  <meta http-equiv="content-type" content="text/html;
                    charset=UTF-8">
                  This belongs in the UI, not the player as I explained
                  in a previous review.<br>
                </blockquote>
                <p>Hi,</p>
                <p>I think you are referring to this review:</p>
                <p> </p>
                <blockquote type="cite">While it likely makes sense at
                  the level of UI widgets and user interactions, it
                  seems a bit out of place, standing alone, at the
                  player API level.<br>
                  <br>
                  In particular, I doubt that enabling multiple tracks
                  mode in Qt should interfere with the track selection
                  of, say, the HTTP remote control.<br>
                  <br>
                  IMO, the API should just take the list of active
                  tracks, whether it be empty, a singleton, or larger.</blockquote>
                <p>Now that we've added the vlc_player_SelectTrackList
                  function, only the first line of your review still
                  needs to be addressed. <br>
                </p>
                <p>If we don't want to use the player API to enable /
                  check if subtitles are enabled, I need a way to
                  enable/disable dual subtitles and keep that synced
                  between the hotkeys, QT GUI and any future interfaces
                  that might allow dual subtitle selection.</p>
                <p>So, if it should belong in the UI as you suggest,
                  could you give some more information on how this might
                  be implemented? How is dual subtitles enabled in
                  interface A and then used to select another subtitle
                  track in interface B or C?<br>
                </p>
                <p>Note: There are other subtitle-related functions
                  (SetSubtitleEnabled, SetSubtitleDelay,
                  GetSubtitleDelay, SetSubtitleSync,
                  SetSubtitleTextScale, GetSubtitleTextScale, ) in the
                  player API too. I think the two methods I added
                  (SetDualSubtitlesEnabled, AreDualSubtitlesEnabled)
                  could fit.</p>
                <br>
                <blockquote type="cite"
                  cite="mid:86A2E34C-22FB-47F8-A627-F87E264D660C@remlab.net"><br>
                  <div class="gmail_quote">Le 28 mai 2019 05:06:54
                    GMT+03:00, Roland Bewick <a
                      class="moz-txt-link-rfc2396E"
                      href="mailto:roland.bewick@gmail.com"
                      moz-do-not-send="true"><roland.bewick@gmail.com></a>
                    a écrit :
                    <blockquote class="gmail_quote" style="margin: 0pt
                      0pt 0pt 0.8ex; border-left: 1px solid rgb(204,
                      204, 204); padding-left: 1ex;">
                      <div>
                        <div>
                          <div>
                            <div dir="auto">So the state has to be
                              linked across the interfaces. In this case
                              shouldn’t it belong to the player? If not,
                              where?</div>
                            <div dir="auto"><br>
                            </div>
                            <div dir="auto">I like Thomas’ idea: Store
                              the bool in the <span
                                style="color:rgb(49,49,49);word-spacing:1px">vlc_player_t
                                struct.</span></div>
                          </div>
                        </div>
                      </div>
                      <div>
                        <div>
                          <div>
                            <div dir="auto"><br>
                            </div>
                            <div dir="auto">Roland</div>
                            <div><br>
                              <div class="gmail_quote">
                                <div dir="ltr" class="gmail_attr">On
                                  Mon, 27 May 2019 at 11:53 PM, Rémi
                                  Denis-Courmont <<a
                                    href="mailto:remi@remlab.net"
                                    target="_blank"
                                    moz-do-not-send="true">remi@remlab.net</a>>
                                  wrote:<br>
                                </div>
                                <blockquote class="gmail_quote"
                                  style="margin:0 0 0
                                  .8ex;border-left:1px #ccc
                                  solid;padding-left:1ex">Le maanantaina
                                  27. toukokuuta 2019, 10.19.43 EEST
                                  Thomas Guillem a écrit :<br>
                                  > Hello,<br>
                                  > <br>
                                  > This should not belong to the
                                  player.<br>
                                  > I think you should store the
                                  internal dual subtitle state in each<br>
                                  > interfaces.<br>
                                  <br>
                                  Yes and I wrote something to same
                                  effect in a previous review.<br>
                                  <br>
                                  -- <br>
                                  Rémi Denis-Courmont<br>
                                  <a href="http://www.remlab.net/"
                                    rel="noreferrer" target="_blank"
                                    moz-do-not-send="true">http://www.remlab.net/</a><br>
                                  <br>
                                  <br>
                                  <br>
_______________________________________________<br>
                                  vlc-devel mailing list<br>
                                  To unsubscribe or modify your
                                  subscription options:<br>
                                  <a
                                    href="https://mailman.videolan.org/listinfo/vlc-devel"
                                    rel="noreferrer" target="_blank"
                                    moz-do-not-send="true">https://mailman.videolan.org/listinfo/vlc-devel</a></blockquote>
                              </div>
                            </div>
                          </div>
                        </div>
                      </div>
                    </blockquote>
                  </div>
                  <br>
                  -- <br>
                  Envoyé de mon appareil Android avec Courriel K-9 Mail.
                  Veuillez excuser ma brièveté. <br>
                  <fieldset class="mimeAttachmentHeader"></fieldset>
                  <pre class="moz-quote-pre" wrap="">_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a class="moz-txt-link-freetext" href="https://mailman.videolan.org/listinfo/vlc-devel" moz-do-not-send="true">https://mailman.videolan.org/listinfo/vlc-devel</a></pre>
                </blockquote>
              </blockquote>
            </div>
            <br>
            -- <br>
            Envoyé de mon appareil Android avec Courriel K-9 Mail.
            Veuillez excuser ma brièveté. <br>
            <fieldset class="mimeAttachmentHeader"></fieldset>
            <pre class="moz-quote-pre" wrap="">_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a class="moz-txt-link-freetext" href="https://mailman.videolan.org/listinfo/vlc-devel" moz-do-not-send="true">https://mailman.videolan.org/listinfo/vlc-devel</a></pre>
          </blockquote>
        </blockquote>
      </div>
      <br>
      -- <br>
      Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
      excuser ma brièveté.
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <pre class="moz-quote-pre" wrap="">_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a class="moz-txt-link-freetext" href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre>
    </blockquote>
  </body>
</html>