<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div><br></div><div>On Tue, May 28, 2019, at 12:15, Roland Bewick wrote:<br></div><blockquote type="cite" id="qt"><p><br></p><div class="qt-moz-cite-prefix">On 28/05/2019 5:09 PM, Rémi
Denis-Courmont wrote:<br></div><blockquote cite="mid:85F4C2A4-9AA6-4FD6-9BB7-9F74C9C072DB@remlab.net" type="cite"><div>I'm trying to keep things simple by not leaking stuff across UIs
especially when some won't handle it.<br></div><div> <br></div><div> Since separate hotkeys are already there, I don't see why you need
a flag at all as far as hotkeys are concerned.<br></div><div> <br></div><div> <br></div><div class="qt-gmail_quote">Le 28 mai 2019 12:23:58 GMT+03:00, Roland
Bewick <a href="mailto:roland.bewick@gmail.com" class="qt-moz-txt-link-rfc2396E"><roland.bewick@gmail.com></a> a écrit :<br></div></blockquote><p>Yes. There is no problem in that scenario. But, If you select
dual subtitles in the hotkeys first, dual subtitles won't be
enabled in the QT GUI.<br></p><p>(Two tracks will be selected in the menu while the "Enable Dual
Subtitles" option is unselected).<br></p><p>Roland<br></p></blockquote><div><br></div><div><br></div><div>Maybe you could save this parameter as a variable (like "multiple-spus") in the root vlc object.<br></div><div><br></div><blockquote type="cite" id="qt"><blockquote cite="mid:85F4C2A4-9AA6-4FD6-9BB7-9F74C9C072DB@remlab.net" type="cite"><div class="qt-gmail_quote"><blockquote style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="qt-gmail_quote"><p><br></p><div class="qt-moz-cite-prefix">On 28/05/2019 1:38 PM, Rémi
Denis-Courmont wrote:<br></div><blockquote cite="mid:5456F6F1-DD27-4716-8026-2F88DC54B721@remlab.net" type="cite"><div>Hi,<br></div><div> <br></div><div> The whole point of adding a call to atomically select all
SPU ES is that we don't need to keep UIs in sync.<br></div><div> <br></div><div> Keeping that stuff synched would break existing UIs that
don't support multiple SPU, which are not going to disappear
overnight.<br></div><div> <br></div><div> And it would require some code-complex and
user-uninteligible transaction model... Or what will happen
if a UI asks to enable two SPU's after another UI disabled
multiple SPU's??<br></div><div> <br></div><div> <br></div><div class="qt-gmail_quote">Le 28 mai 2019 08:45:41 GMT+03:00,
Roland Bewick <a href="mailto:roland.bewick@gmail.com" class="qt-moz-txt-link-rfc2396E"><roland.bewick@gmail.com></a> a écrit :<br></div></blockquote><p>Hi, please refer to Jean-Baptiste's requirement: "If you
enable dual-spu in Qt, it must work in the hotkeys.",<br></p><p>As to the existing UIs - They don't use the new
vlc_player_SelectTrackList function.<br></p><p>I feel like you're making this over-complicated.<br></p><p><br></p><p><br></p><blockquote cite="mid:5456F6F1-DD27-4716-8026-2F88DC54B721@remlab.net" type="cite"><div class="qt-gmail_quote"><blockquote style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="qt-gmail_quote"><p><br></p><div class="qt-moz-cite-prefix">On 28/05/2019 12:12 PM,
Rémi Denis-Courmont wrote:<br></div><blockquote cite="mid:86A2E34C-22FB-47F8-A627-F87E264D660C@remlab.net" type="cite">This belongs in the UI, not the player as I explained
in a previous review.<br></blockquote><p>Hi,<br></p><p>I think you are referring to this review:<br></p><p><br></p><blockquote type="cite"><div>While it likely makes sense at
the level of UI widgets and user interactions, it
seems a bit out of place, standing alone, at the
player API level.<br></div><div> <br></div><div> In particular, I doubt that enabling multiple tracks
mode in Qt should interfere with the track selection
of, say, the HTTP remote control.<br></div><div> <br></div><div> IMO, the API should just take the list of active
tracks, whether it be empty, a singleton, or larger.<br></div></blockquote><p>Now that we've added the vlc_player_SelectTrackList
function, only the first line of your review still
needs to be addressed. <br></p><p>If we don't want to use the player API to enable /
check if subtitles are enabled, I need a way to
enable/disable dual subtitles and keep that synced
between the hotkeys, QT GUI and any future interfaces
that might allow dual subtitle selection.<br></p><p>So, if it should belong in the UI as you suggest,
could you give some more information on how this might
be implemented? How is dual subtitles enabled in
interface A and then used to select another subtitle
track in interface B or C?<br></p><p>Note: There are other subtitle-related functions
(SetSubtitleEnabled, SetSubtitleDelay,
GetSubtitleDelay, SetSubtitleSync,
SetSubtitleTextScale, GetSubtitleTextScale, ) in the
player API too. I think the two methods I added
(SetDualSubtitlesEnabled, AreDualSubtitlesEnabled)
could fit.<br></p><div><br></div><blockquote cite="mid:86A2E34C-22FB-47F8-A627-F87E264D660C@remlab.net" type="cite"><div><br></div><div class="qt-gmail_quote"><div>Le 28 mai 2019 05:06:54
GMT+03:00, Roland Bewick <a href="mailto:roland.bewick@gmail.com" class="qt-moz-txt-link-rfc2396E"><roland.bewick@gmail.com></a> a écrit : <br></div><blockquote style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="qt-gmail_quote"><div><div><div><div dir="auto">So the state has to be
linked across the interfaces. In this case
shouldn’t it belong to the player? If not,
where?<br></div><div dir="auto"><br></div><div dir="auto">I like Thomas’ idea: Store
the bool in the <span style="color:rgb(49, 49, 49)" class="colour">vlc_player_t
struct.</span><br></div></div></div></div><div><div><div><div dir="auto"><br></div><div dir="auto">Roland<br></div><div><div><br></div><div class="qt-gmail_quote"><div class="qt-gmail_attr" dir="ltr">On
Mon, 27 May 2019 at 11:53 PM, Rémi
Denis-Courmont <<a href="mailto:remi@remlab.net">remi@remlab.net</a>>
wrote:<br></div><blockquote style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="qt-gmail_quote"><div>Le maanantaina
27. toukokuuta 2019, 10.19.43 EEST
Thomas Guillem a écrit :<br></div><div> > Hello,<br></div><div> > <br></div><div> > This should not belong to the
player.<br></div><div> > I think you should store the
internal dual subtitle state in each<br></div><div> > interfaces.<br></div><div> <br></div><div> Yes and I wrote something to same
effect in a previous review.<br></div><div> <br></div><div> -- <br></div><div> Rémi Denis-Courmont<br></div><div> <a rel="noreferrer" href="http://www.remlab.net/">http://www.remlab.net/</a><br></div><div> <br></div><div> <br></div><div> <br></div><div> _______________________________________________<br></div><div> vlc-devel mailing list<br></div><div> To unsubscribe or modify your
subscription options:<br></div><div> <a rel="noreferrer" href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote></div></div></div></div></div></blockquote></div><div><br></div><div>--<br></div><div> Envoyé de mon appareil Android avec Courriel K-9 Mail.
Veuillez excuser ma brièveté. <br></div><div> <br></div><pre class="qt-moz-quote-pre" wrap="">_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a href="https://mailman.videolan.org/listinfo/vlc-devel" class="qt-moz-txt-link-freetext">https://mailman.videolan.org/listinfo/vlc-devel</a><br></pre></blockquote></blockquote></div><div><br></div><div>--<br></div><div> Envoyé de mon appareil Android avec Courriel K-9 Mail.
Veuillez excuser ma brièveté. <br></div><div> <br></div><pre class="qt-moz-quote-pre" wrap="">_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a href="https://mailman.videolan.org/listinfo/vlc-devel" class="qt-moz-txt-link-freetext">https://mailman.videolan.org/listinfo/vlc-devel</a><br></pre></blockquote></blockquote></div><div><br></div><div>--<br></div><div> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
excuser ma brièveté. <br></div><div> <br></div><pre class="qt-moz-quote-pre" wrap="">_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a href="https://mailman.videolan.org/listinfo/vlc-devel" class="qt-moz-txt-link-freetext">https://mailman.videolan.org/listinfo/vlc-devel</a><br></pre></blockquote><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></body></html>