<!doctype html><html><head><title></title><style type="text/css">#qt p.qt-MsoNormal,#qt p.qt-MsoNoSpacing,#qt p.qt-MsoNormal,#qt p.qt-MsoNoSpacing,#qt #qt-qt p.qt-qt-MsoNormal,#qt #qt-qt p.qt-qt-MsoNoSpacing{margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;}
p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body>Hi,<br><br>I don't know what you are on about. We already have a structure to pass per item and per ES meta-infos.<br><br>And while ideally we should distinguish between media-intrinsic meta and extrinsic meta, in practice we don't do that distinction yet. Some meta are neither purely intrinsic nor strictly extrinsic already<br><br><div class="gmail_quote">Le 28 mai 2019 14:58:14 GMT+03:00, Thomas Guillem <thomas@gllm.fr> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><br></div><div>On Tue, May 28, 2019, at 12:54, Rémi Denis-Courmont wrote:<br></div><blockquote type="cite" id="qt"><div>Hi,<br></div><div><br></div><div>Stating the obvious here but the etymology of debug literally means to remove bugs, not add them.<br></div><div><br></div><div>In any case, I can't comment on a version of a patch series that has not been posted. But I'm pretty sure it's worse than putting the packetizer, decoder, hw context and output module names in the ES meta, and the input objects' module names in the input meta.<br></div></blockquote><div><br></div><div>That seems a viable solution. Do you agree that we would need:<br></div><div><br></div><div> - A new data structure returned by the vlc player that wil contain a description of all inputs (and slave)<br></div><div> - Each input description will contains the demuxer/packetizer module name and the list of all stream filters name<br></div><div> - For each ES track exposed by the player, we would need the name of the decoder/packetizer/hw modules + the vout / window modules + the gl interop module name (if any).<br></div><div><br></div><div><br></div><blockquote type="cite" id="qt"><div><br></div><div>Because O(n*n) vs O(1), no serialisation of all object creation and destruction, and most importantly, works in LibVLC and all UIs, not just Qt.<br></div><div><br></div><div class="qt-gmail_quote"><div>Le 28 mai 2019 13:13:57 GMT+03:00, Thomas Guillem <thomas@gllm.fr> a écrit :<br></div><blockquote style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="qt-gmail_quote"><div><br></div><div>On Tue, May 28, 2019, at 11:57, Rémi Denis-Courmont wrote:<br></div><blockquote type="cite" id="qt-qt"><div>I don't think racy is okay for debugging, no. Debugging code should not add bugs.<br></div></blockquote><div><br></div><div>A lot of people seems to disagree with you (cf. previous discussions and trac). I'm not talking about adding new "bugs", but about restoring our good old "bugs" back to get a feature that was used a lot. There is a huge difference. Specially, since we didn't had the chance to review this removal.<br></div><div><br></div><div>Having said that, I don't see bugs in my branch. There is no race anymore when you could get dead object returned by vlc_list_children. There is a just a race between object and object module name.<br></div><div><br></div><blockquote type="cite" id="qt-qt"><div><br></div><div>Besides, I don't see how you can have an object whose type and lifecycle is unknown so the problem is moot.<br></div><div><br></div><div class="qt-qt-gmail_quote"><div>Le 28 mai 2019 11:56:25 GMT+03:00, Thomas Guillem <thomas@gllm.fr> a écrit :<br></div><blockquote style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="qt-qt-gmail_quote"><div><br></div><div>On Tue, May 28, 2019, at 10:48, Rémi Denis-Courmont wrote:<br></div><blockquote id="qt-qt-qt" type="cite"><div>Hi,<br></div><div><br></div><div>To get the name of a loaded module call module_get_name() on the module pointer. To get the name of your own module, use MODULE_STRING. To get the name of a module used by somebody else's object, use vlc_object_get_name() but that's intrinsically racy and unreliable.<br></div></blockquote><div><br></div><div>As already said, racy and unreliable is ok for debugging purpose.<br></div><div>As already said, cf. PATCH 7/7: vlc_object_get_name() doesn't work when module are loaded with vlc_module_load().<br></div><div><br></div><blockquote id="qt-qt-qt" type="cite"><div><br></div><div class="qt-qt-qt-gmail_quote"><div>Le 28 mai 2019 11:24:11 GMT+03:00, Thomas Guillem <thomas@gllm.fr> a écrit :<br></div><blockquote class="qt-qt-qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><pre class="qt-qt-qt-k9mail"><div><br></div><div>On Tue, May 28, 2019, at 10:03, Rémi Denis-Courmont wrote:<br></div><blockquote class="qt-qt-qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div>The "feature"(s) of getting the name of a module and getting the module <br></div><div>of an object are still there. No news here.<br></div></blockquote><div><br></div><div>How do you get the module of an object ? Did you see 7/7 ?<br></div><div><br></div><div>> <br></div><blockquote class="qt-qt-qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div>This patchset is removing one of the two ways to get there though.<br></div><div><br></div><div>Le 28 mai 2019 09:39:22 GMT+03:00, Thomas Guillem <thomas@gllm.fr> a écrit :<br></div><blockquote class="qt-qt-qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(173, 127, 168);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div>On Mon, May 27, 2019, at 18:41, Rémi Denis-Courmont wrote:<br></div><blockquote class="qt-qt-qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(138, 226, 52);border-left-style:solid;border-left-width:1px;padding-left:1ex;">Le maanantaina 27. toukokuuta 2019, 19.15.56 EEST Thomas Guillem a<br></blockquote><div>écrit :<br></div><blockquote class="qt-qt-qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(138, 226, 52);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><blockquote class="qt-qt-qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(252, 175, 62);border-left-style:solid;border-left-width:1px;padding-left:1ex;">I mean I can store the module name instead of the module.<br></blockquote><div>We already store the module name in the object.<br></div><div><br></div><div>Leaving aside that it's a racy ugly hack, it's already there without<br></div></blockquote><div>needing <br></div><blockquote class="qt-qt-qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(138, 226, 52);border-left-style:solid;border-left-width:1px;padding-left:1ex;">any changes.<br></blockquote><div>It's just a hack that I try to put back in order to restore a feature.<br></div><div>No news here.<br></div><div><br></div><blockquote class="qt-qt-qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(138, 226, 52);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div>-- <br></div><div>雷米‧德尼-库尔蒙<br></div><div><a href="http://www.remlab.net/">http://www.remlab.net/</a><hr>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote><div><hr>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote><div>-- <br></div><div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser <br></div><div>ma brièveté.<hr>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote><div><hr>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></pre></blockquote></div><div><br></div><div>-- <br></div><div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></blockquote></div><div><br></div><div>-- <br></div><div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></blockquote></div><div><br></div><div>-- <br></div><div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>