<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div dir="ltr"><br></div><div dir="ltr"><br>Am 06.06.2019 um 17:49 schrieb Rémi Denis-Courmont <<a href="mailto:remi@remlab.net">remi@remlab.net</a>>:<br><br></div><blockquote type="cite"><div dir="ltr">Hi,<br><br>You can't have it both ways. It can't be exported to be used by children processes and not exported at the same time to not interfere with Meson assumptions.<br></div></blockquote><div><br></div><div>I do not want to export those to be used by child processes, all I need is custom flags that contrib make uses, the contrib make already overrides the env variables of the scripts it calls using the HOSTVARS anyway?</div><div><br></div><div>Although it seems I completely overlooked that I can just use make variables and do not need to fiddle with the env at all, I guess.</div><div><br></div><blockquote type="cite"><div dir="ltr"><br>(And I share Steve's concerns that this might break a lot of existing rules.)<br><br></div></blockquote><blockquote type="cite"><div dir="ltr"><div class="gmail_quote">Le 6 juin 2019 17:10:40 GMT+03:00, Marvin Scholz <<a href="mailto:epirat07@gmail.com">epirat07@gmail.com</a>> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail"><br><br>On 6 Jun 2019, at 16:09, Rémi Denis-Courmont wrote:<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> Hi,<br><br> Unexport sounds like a brittle hack to me. Don't export in the first <br> place if you don't want to.<br><br></blockquote><br>How else would I set for example custom CFLAGS or the C compiler to use <br>for contrib builds?<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Le 6 juin 2019 14:45:58 GMT+03:00, Marvin Scholz <<a href="mailto:epirat07@gmail.com">epirat07@gmail.com</a>> <br>a écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> Meson always interprets these env variables for the build compiler,<br> even when cross-compiling, therefore we need to unset them,<br> they are anyway included in HOSTVARS already for other build systems.<hr> contrib/src/main.mak | 22 +++++++++++++++++++---<br> 1 file changed, 19 insertions(+), 3 deletions(-)<br><br> diff --git a/contrib/src/main.mak b/contrib/src/main.mak<br> index 8944a5a1d7..b4da1b556e 100644<br> --- a/contrib/src/main.mak<br> +++ b/contrib/src/main.mak<br> @@ -329,9 +329,25 @@ HOSTVARS_PIC := $(HOSTTOOLS) \<br> CXXFLAGS="$(CXXFLAGS) $(PIC)" \<br> LDFLAGS="$(LDFLAGS)"<br><br> -# Keep a version of HOSTVARS without the tools, since meson requires<br> the<br> -# tools variables to point to the native ones<br> -HOSTVARS_MESON := $(HOSTVARS)<br> +# For cross-compilation with meson, we need to unset compiler and<br> flags<br> +# env variables as meson will always use them for the BUILD machine<br> compiler!<br> +ifdef HAVE_CROSS_COMPILE<br> +HOSTVARS_MESON :=<br> +unexport CC<br> +unexport CXX<br> +unexport LD<br> +unexport AR<br> +unexport CCAS<br> +unexport RANLIB<br> +unexport STRIP<br> +unexport CPPFLAGS<br> +unexport CFLAGS<br> +unexport CXXFLAGS<br> +unexport LDFLAGS<br> +else<br> +HOSTVARS_MESON := $(HOSTTOOLS) $(HOSTVARS)<br> +endif<br> +<br> HOSTVARS := $(HOSTTOOLS) $(HOSTVARS)<br><br> download_git = \<br> -- <br> 2.20.1 (Apple Git-117)<hr> vlc-devel mailing list<br> To unsubscribe or modify your subscription options:<br> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez <br>excuser ma brièveté._______________________________________________<br>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</div></blockquote><blockquote type="cite"><div dir="ltr"><span>_______________________________________________</span><br><span>vlc-devel mailing list</span><br><span>To unsubscribe or modify your subscription options:</span><br><span><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></span></div></blockquote></body></html>