<html><head></head><body>Yes, it works on top of other private push-buffer patches, but not master. Nevermind.<br><br><div class="gmail_quote">Le 14 juin 2019 14:43:22 GMT+08:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">You are missing this very important line:<br><br><a href="http://git.videolan.org/?p=vlc.git;a=blob;f=src/video_output/vout_wrapper.c;h=61046f2be0f35e25df846acadfe9adac5fd7bdf9;hb=HEAD#l96">http://git.videolan.org/?p=vlc.git;a=blob;f=src/video_output/vout_wrapper.c;h=61046f2be0f35e25df846acadfe9adac5fd7bdf9;hb=HEAD#l96</a><br><br>I think the invalid picture can be removed after we have done the push. <br>But for now it still serves a purpose.<br><br>On 2019-06-14 6:49, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><hr> include/vlc_vout_display.h | 1 -<br> modules/video_output/win32/direct3d9.c | 1 -<br> src/video_output/display.c | 1 -<br> 3 files changed, 3 deletions(-)<br><br>diff --git a/include/vlc_vout_display.h b/include/vlc_vout_display.h<br>index 97a6c96c1b..96af8ca756 100644<br>--- a/include/vlc_vout_display.h<br>+++ b/include/vlc_vout_display.h<br>@@ -106,7 +106,6 @@ typedef struct vout_display_cfg {<br> */<br> typedef struct {<br> bool is_slow; /* The picture memory has slow read/write */<br>- bool has_pictures_invalid; /* Can handle VOUT_DISPLAY_RESET_PICTURES */<br> bool can_scale_spu; /* Handles subpictures with a non default zoom factor */<br> const vlc_fourcc_t *subpicture_chromas; /* List of supported chromas for subpicture rendering. */<br> } vout_display_info_t;<br>diff --git a/modules/video_output/win32/direct3d9.c b/modules/video_output/win32/direct3d9.c<br>index da4f4a8e7c..f5e9fef856 100644<br>--- a/modules/video_output/win32/direct3d9.c<br>+++ b/modules/video_output/win32/direct3d9.c<br>@@ -1773,7 +1773,6 @@ static int Open(vout_display_t *vd, const vout_display_cfg_t *cfg,<br> <br> /* Setup vout_display now that everything is fine */<br> vd->info.is_slow = false;<br>- vd->info.has_pictures_invalid = !is_d3d9_opaque(fmt.i_chroma);<br> <br> if (var_InheritBool(vd, "direct3d9-hw-blending") &&<br> sys->d3dregion_format != D3DFMT_UNKNOWN &&<br>diff --git a/src/video_output/display.c b/src/video_output/display.c<br>index a996694a51..953ff7b132 100644<br>--- a/src/video_output/display.c<br>+++ b/src/video_output/display.c<br>@@ -367,7 +367,6 @@ void vout_display_SendEventPicturesInvalid(vout_display_t *vd)<br> vout_display_priv_t *osys = container_of(vd, vout_display_priv_t, display);<br> <br> msg_Err(vd, "picture buffers invalidated asynchronously");<br>- assert(vd->info.has_pictures_invalid);<br> atomic_store_explicit(&osys->reset_pictures, true, memory_order_release);<br> #else<br> (void) vd;<br>-- <br>2.20.1<hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>