<html><head></head><body>Hi,<br><br>To be precise, the spec stated that it must be an unsigned of at least 32 bits.<br><br>Now the spec only states that it must be at least 32-bits and that the sign bit should be left alone to avoid portability problems.<br><br><div class="gmail_quote">Le 17 juin 2019 09:40:33 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 2019-06-16 16:35, KO Myung-Hun wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">OS/2 socket APIs use int not unsigned int in place of socklen_t. As<br>a result, compilation is stopped at function call requiring socklen_t *<br>because of type mismatch between int * and unsigned int *.<br></blockquote><br>the spec says that socklen_t should be an unsigned integer of at least <br>32 bits. So for OS/2 you may need an int64. But if pointers are used <br>that's not an option. So the patch should conditionally define socklen_t <br>to what you want only for OS/2. The rest of the time it should be as it <br>is now.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><hr> configure.ac | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br><br>diff --git a/configure.ac b/configure.ac<br>index b38f693989..9e9d56d2b6 100644<br>--- a/configure.ac<br>+++ b/configure.ac<br>@@ -762,7 +762,7 @@ ac_cv_type_socklen_t,<br> ac_cv_type_socklen_t=yes,<br> ac_cv_type_socklen_t=no)])<br> AS_IF([test "$ac_cv_type_socklen_t" = no],<br>- [AC_DEFINE(socklen_t, unsigned int)])<br>+ [AC_DEFINE(socklen_t, int)])<br> <br> dnl Check for struct sockaddr_storage<br> AH_TEMPLATE(sockaddr_storage, [Define to `sockaddr' if <sys/socket.h> does not define.]) dnl ` (fix VIM syntax highlight<br>-- <br>2.13.3<hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>