<!doctype html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body>Hi,<br><br>Core uses shift+Unicode code point. Nothing says it has to be Latin 1 subset code point.<br><br><div class="gmail_quote">Le 18 juin 2019 12:26:40 GMT+03:00, Thomas Guillem <thomas@gllm.fr> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><br></div><div>On Mon, Dec 3, 2018, at 12:00, Rémi Denis-Courmont wrote:<br></div><blockquote type="cite" id="qt"><div>Your humble opinion is not the question here. I don't think the design of VLC core has any bearing on X11 keyboard maps.<br></div></blockquote><div><br></div><div>VLC shortcut with "Shift+key" don't work without this patch.<br></div><div><br></div><blockquote type="cite" id="qt"><div><br></div><div class="qt-gmail_quote"><div>Le 3 décembre 2018 12:24:51 GMT+02:00, Victorien Le Couviour <victorien.lecouviour.tuffet@gmail.com> a écrit :<br></div><blockquote style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="qt-gmail_quote"><div dir="ltr"><div>Hi,<br></div><div><br></div><div>Since the core expects it to be this way and is unaware of the layout, imho yes.<br></div></div><div><br></div><div class="qt-gmail_quote"><div dir="ltr">On Thu, Nov 29, 2018 at 2:54 PM Rémi Denis-Courmont <<a href="mailto:remi@remlab.net">remi@remlab.net</a>> wrote:<br></div><blockquote style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="qt-gmail_quote"><div><div>Hi,<br></div><div><br></div><div>That looks correct on simple Latin-only keyboard layouts, but does that assumption on shift and case apply to all layouts?<br></div></div></blockquote></div></blockquote></div></blockquote><div><br></div><div>VLC shortcuts use latin key anyway ("Shift+k" for example), so I don't get how it affect non latin keyboards.<br></div><div><br></div><blockquote type="cite" id="qt"><div class="qt-gmail_quote"><blockquote style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="qt-gmail_quote"><div class="qt-gmail_quote"><blockquote style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="qt-gmail_quote"><div><div><br></div><div class="qt-gmail_quote"><div>Le 28 novembre 2018 16:12:23 GMT+02:00, Victorien Le Couviour--Tuffet <<a href="mailto:victorien.lecouviour.tuffet@gmail.com">victorien.lecouviour.tuffet@gmail.com</a>> a écrit :<br></div><blockquote style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="qt-gmail_quote"><pre class="qt-m_-7323591372044683066k9mail"><div>The core expects keycodes to be all lowercase. If the shift key is<br></div><div>pressed, then the keycode will contain the SHIFT modifier.<br></div><div>xkb_state_key_get_one_sym performs capitalization, because of this all<br></div><div>actions having SHIFT in their mapped keycode were not triggered.<hr> modules/video_output/xcb/xkb.c | 8 ++++----<br></div><div> 1 file changed, 4 insertions(+), 4 deletions(-)<br></div><div><br></div><div>diff --git a/modules/video_output/xcb/xkb.c b/modules/video_output/xcb/xkb.c<br></div><div>index 35384ee4c7..813ee8e79e 100644<br></div><div>--- a/modules/video_output/xcb/xkb.c<br></div><div>+++ b/modules/video_output/xcb/xkb.c<br></div><div>@@ -32,6 +32,9 @@<br></div><div> #include <vlc_actions.h><br></div><div> #include "video_output/xcb/vlc_xkb.h"<br></div><div> <br></div><div>+#ifdef HAVE_XKBCOMMON<br></div><div>+# include <xkbcommon/xkbcommon.h><br></div><div>+<br></div><div> static int keysymcmp (const void *pa, const void *pb)<br></div><div> {<br></div><div> int a = *(const uint32_t *)pa;<br></div><div>@@ -54,7 +57,7 @@ static uint_fast32_t vlc_xkb_convert_keysym(uint_fast32_t sym)<br></div><div> <br></div><div> /* X11 Latin-1 range */<br></div><div> if (sym <= 0xff)<br></div><div>- return sym;<br></div><div>+ return xkb_keysym_to_lower(sym);<br></div><div> /* X11 Unicode range */<br></div><div> if (sym >= 0x1000100 && sym <= 0x110ffff)<br></div><div> return sym - 0x1000000;<br></div><div>@@ -90,9 +93,6 @@ static uint_fast32_t vlc_xkb_convert_keysym(uint_fast32_t sym)<br></div><div> return KEY_UNSET;<br></div><div> }<br></div><div> <br></div><div>-#ifdef HAVE_XKBCOMMON<br></div><div>-# include <xkbcommon/xkbcommon.h><br></div><div>-<br></div><div> struct modifiers<br></div><div> {<br></div><div> char name[8];<br></div></pre></blockquote></div><div><br></div><div>-- <br></div><div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.<br></div></div><div>_______________________________________________<br></div><div> vlc-devel mailing list<br></div><div> To unsubscribe or modify your subscription options:<br></div><div> <a rel="noreferrer" href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote></div></blockquote></div><div><br></div><div>-- <br></div><div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>