<html><head></head><body>Hi,<br><br>This looks like it'll cause too eager dependencies and too systematic rebuild of libvlc{,core}. I think we used to do something similar and purposefully stopped.<br><br><div class="gmail_quote">Le 21 juin 2019 00:33:17 GMT+02:00, Marvin Scholz <epirat07@gmail.com> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">Instead of generating the revision.c file in the source tree<br>and including the c file in lib/core.c, generate a .h file in the<br>build dir and include that instead.<hr> lib/core.c | 2 +-<br> src/Makefile.am | 7 +++----<br> src/libvlc.c | 1 +<br> 3 files changed, 5 insertions(+), 5 deletions(-)<br><br>diff --git a/lib/core.c b/lib/core.c<br>index 06fd52fbfa..c1fb78b7cf 100644<br>--- a/lib/core.c<br>+++ b/lib/core.c<br>@@ -34,7 +34,7 @@<br> #include <limits.h><br> #include <assert.h><br> <br>-#include "../src/revision.c"<br>+#include "../src/revision.h"<br> <br> libvlc_instance_t * libvlc_new( int argc, const char *const *argv )<br> {<br>diff --git a/src/Makefile.am b/src/Makefile.am<br>index 3f73999fdb..b25df0b56e 100644<br>--- a/src/Makefile.am<br>+++ b/src/Makefile.am<br>@@ -198,7 +198,6 @@ libvlccore_la_SOURCES = \<br> libvlc.h \<br> libvlc-module.c \<br> missing.c \<br>- revision.c \<br> version.c \<br> config/configuration.h \<br> config/core.c \<br>@@ -618,10 +617,10 @@ LDADD = libvlccore.la \<br> # GIT revision<br> ###############################################################################<br> <br>-BUILT_SOURCES += stamp-revision<br>-MAINTAINERCLEANFILES = $(srcdir)/revision.txt $(srcdir)/revision.c<br>+BUILT_SOURCES += stamp-revision revision.h<br>+MAINTAINERCLEANFILES = $(srcdir)/revision.txt revision.h<br> <br>-$(srcdir)/revision.c: $(srcdir)/revision.txt<br>+revision.h: $(srcdir)/revision.txt<br> $(AM_V_at)rm -f -- $@<br> $(AM_V_GEN)echo "const char psz_vlc_changeset[] = \"$$(cat $<)\";" \<br> > $@<br>diff --git a/src/libvlc.c b/src/libvlc.c<br>index 018987f0bf..d65258761f 100644<br>--- a/src/libvlc.c<br>+++ b/src/libvlc.c<br>@@ -65,6 +65,7 @@<br> #include <vlc_thumbnailer.h><br> <br> #include "libvlc.h"<br>+#include "revision.h"<br> <br> #include <vlc_vlm.h><br> </pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>