<div><div><br></div><div><br><div class="gmail_quote"></div></div></div><div><div dir="ltr" class="gmail_attr">On Sat, 22 Jun 2019 at 12:29 AM, Alexandre Janniaux <<a href="mailto:ajanni@videolabs.io" target="_blank">ajanni@videolabs.io</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
I didn't checked the code, only the gif, but maybe you can use a different QML<br>
component that doesn't trigger the close of the menu ?</blockquote><div dir="auto"><br></div></div><div><div dir="auto">Isn’t it standard behaviour for the menu to close when an option is clicked? Anyway, I was just trying to point out that I had implemented what Thomas thought was missing:</div></div><div dir="auto"><br></div><div dir="auto">“Multiple tracks selection inside Qt should be more graphical, like adding a checking in tracks selection to enable multiple mode, then selecting a track will add it instead of replacing it.”</div><div><div><div class="gmail_quote"><div dir="auto"><br></div><div dir="auto">There were some unsolved issues though with the API but Thomas’ changes have solved them I think.</div><div dir="auto"><br></div><div dir="auto"><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
<br>
Regards,<br>
<br>
-- <br>
Alexandre Janniaux<br>
VideoLabs<br>
<br>
<br>
On Fri, Jun 21, 2019 at 12:58:46PM +0700, Roland Bewick wrote:<br>
> <br>
> On 20/06/2019 10:23 PM, Thomas Guillem wrote:<br>
> > Hello,<br>
> > <br>
> > Here is the result of the merge of Roland Bewick work about dual subtitles<br>
> > handling.<br>
> > <br>
> > I started from Roland's work but did some modifications, mainly for polishing<br>
> > the player API regarding multiple tracks handling. For now, only multiple video<br>
> > and dual subtitles are supported, but we won't have to modify the player API if<br>
> > we add multiple audio support later.<br>
> > <br>
> > I rejected the change regarding dual tracks selection in Qt. I didn't like the<br>
> > way it interacted with the hotkeys plugin. Multiple tracks selection inside Qt<br>
> > should be more graphical, like adding a checking in tracks selection to enable<br>
> > multiple mode, then selecting a track will add it instead of replacing it.<br>
> <br>
> That's what I added, see a gif:<br>
> <a href="https://gyazo.com/5520dee77935f14020cb879a791e24c1" rel="noreferrer" target="_blank">https://gyazo.com/5520dee77935f14020cb879a791e24c1</a><br>
> <br>
> The only issue was that the checkboxes show rather than radio buttons when<br>
> dual subtitles is disabled. But that is an existing bug.<br>
> <br>
> Now that you've made the changes to retrieve the spu_order for a vlc_es_id,<br>
> I think the interaction between the QT interface and hotkeys plugin is<br>
> minimal. In fact, as far as I can see the only requirement is for the QT<br>
> interface to listen to track selection changes and toggle the "Enable Dual<br>
> Subtitles" checkbox if there is a track with<br>
> VLC_SPU_CHANNEL_ORDER_SECONDARY.<br>
> <br>
> Other than that, I'm happy with your changes. Thank you for picking up my<br>
> work and seeing it to completion :-)<br>
> <br>
> > <br>
> > The player gained finer controls with SPU tracks. Indeed, users can know which<br>
> > vout is linked with wich SPU tracks, and if a SPU track is primary or secondary.<br>
> > <br>
> > Regards,<br>
> > Thomas<br>
> > <br>
> > Roland Bewick (12):<br>
> > demux: add DEMUX_SET_ES_LIST control<br>
> > input: add INPUT_CONTROL_SET_ES_LIST<br>
> > player: add vlc_player_SelectEsIdList<br>
> > vout: spu: handle secondary channel order<br>
> > vout: spu: pass channel order to vout_ChangeSubMargin<br>
> > player: handle secondary-sub-margin notification<br>
> > libvlc: add secondary sub options<br>
> > libvlc: add a key to switch spu channel orders<br>
> > vout: handle secondary-sub-margin callback<br>
> > hotkeys: handle secondary subtitles options<br>
> > qt: add secondary sub margin/alignment preferences<br>
> > qt: add secondary subtitle delay synchronization<br>
> > <br>
> > Thomas Guillem (8):<br>
> > input: add input_SetEsIdDelay<br>
> > es_out: handle all tracks delays in EsOutGetTracksDelay<br>
> > player: add vlc_player_SetEsIdDelay<br>
> > vout: spu: use mutex instead of atomic<br>
> > input: pass vout and spu_order via events<br>
> > player: rename vlc_player_GetVoutFromEsId<br>
> > player: get vout and spu channel order from SPU es_ids<br>
> > qt: re-indent after last commit<br>
> > <br>
> > include/vlc_actions.h | 2 +<br>
> > include/vlc_demux.h | 3 +-<br>
> > include/vlc_es_out.h | 1 +<br>
> > include/vlc_player.h | 93 +++++++++-<br>
> > include/vlc_vout.h | 10 +<br>
> > lib/media_player.c | 9 +-<br>
> > modules/access/bluray.c | 3 +<br>
> > modules/control/gestures.c | 8 +-<br>
> > modules/control/hotkeys.c | 154 +++++++++++++--<br>
> > modules/demux/adaptive/plumbing/FakeESOut.cpp | 1 +<br>
> > modules/demux/asf/asf.c | 3 +<br>
> > modules/demux/mock.c | 2 +<br>
> > modules/demux/mpeg/ts.c | 10 +-<br>
> > .../gui/macosx/playlist/VLCPlayerController.m | 7 +-<br>
> > modules/gui/qt/components/extended_panels.cpp | 44 ++++-<br>
> > modules/gui/qt/components/extended_panels.hpp | 2 +<br>
> > .../gui/qt/components/player_controller.cpp | 98 ++++++++--<br>
> > .../gui/qt/components/player_controller.hpp | 4 +<br>
> > .../gui/qt/components/player_controller_p.hpp | 6 +-<br>
> > .../gui/qt/components/simple_preferences.cpp | 3 +<br>
> > modules/gui/qt/ui/sprefs_subtitles.ui | 91 +++++++++<br>
> > .../chromecast/chromecast_demux.cpp | 1 +<br>
> > src/input/decoder.c | 40 +++-<br>
> > src/input/demux.c | 1 +<br>
> > src/input/es_out.c | 100 +++++++++-<br>
> > src/input/es_out.h | 8 +<br>
> > src/input/es_out_timeshift.c | 2 +<br>
> > src/input/event.h | 9 +<br>
> > src/input/input.c | 49 +++++<br>
> > src/input/input_internal.h | 23 +++<br>
> > src/input/player.c | 175 +++++++++++++++++-<br>
> > src/libvlc-module.c | 29 +++<br>
> > src/libvlccore.sym | 6 +-<br>
> > src/misc/actions.c | 1 +<br>
> > src/video_output/video_output.c | 10 +-<br>
> > src/video_output/vout_internal.h | 10 +-<br>
> > src/video_output/vout_intf.c | 22 ++-<br>
> > src/video_output/vout_subpictures.c | 107 ++++++++---<br>
> > test/src/input/player.c | 5 +-<br>
> > 39 files changed, 1056 insertions(+), 96 deletions(-)<br>
> > <br>
> _______________________________________________<br>
> vlc-devel mailing list<br>
> To unsubscribe or modify your subscription options:<br>
> <a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a></blockquote></div></div>
</div>