<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div><br></div><div>On Tue, Jun 25, 2019, at 15:03, Rémi Denis-Courmont wrote:<br></div><blockquote type="cite" id="qt"><div>Hi,<br></div><div><br></div><div>Ok given that it does not change the current behaviour. But I don't think picture_NewFromFormat() will be a suitable default. In general allocating and freeing a picture every time is too slow, so we will need some sort of pool per decoder.<br></div></blockquote><div><br></div><div>For info, on linux, on my desktop, it's faster to allocate a 4K picture each time rather than locking/getting/unlocking from a pool.<br></div><div>But I guess results are different on many OSes.<br></div><div><br></div><blockquote type="cite" id="qt"><div><br></div><div class="qt-gmail_quote"><div>Le 25 juin 2019 14:53:12 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<br></div><blockquote style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="qt-gmail_quote"><pre class="qt-k9mail"><div>Create a picture_t on the fly by default.<hr> src/input/decoder_helpers.c | 2 ++<br></div><div> 1 file changed, 2 insertions(+)<br></div><div><br></div><div>diff --git a/src/input/decoder_helpers.c b/src/input/decoder_helpers.c<br></div><div>index 1c4593db30..7384e2bda0 100644<br></div><div>--- a/src/input/decoder_helpers.c<br></div><div>+++ b/src/input/decoder_helpers.c<br></div><div>@@ -88,6 +88,8 @@ int decoder_UpdateVideoFormat( decoder_t *dec )<br></div><div> picture_t *decoder_NewPicture( decoder_t *dec )<br></div><div> {<br></div><div> vlc_assert( dec->fmt_in.i_cat == VIDEO_ES && dec->cbs != NULL );<br></div><div>+ if (dec->cbs->video.buffer_new == NULL)<br></div><div>+ return picture_NewFromFormat( &dec->fmt_out.video );<br></div><div> return dec->cbs->video.buffer_new( dec );<br></div><div> } <br></div></pre></blockquote></div><div><br></div><div>-- <br></div><div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></body></html>