<html><head></head><body>Hi,<br><br>Ultimately, for any given window type, the window size is just a convention between all window and display plugins using that type. It is but a pair of integers that gets passed on from the window to the display.<br><br>As such, it is possible to skip reporting a/the size altogether, or whatever. However, it does not make sense for a display to report the size; that would schizophrenic.<br><br><div class="gmail_quote">Le 3 juillet 2019 08:48:45 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">Hi,<br><br>On 2019-07-02 16:30, Felix Paul Kühne wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">vlc | branch: master | Felix Paul Kühne <felix@feepk.net> | Tue Jul 2 16:29:13 2019 +0200| [adc359f6c9be9b5f232adadd8f7f4f1167c8e79a] | committer: Felix Paul Kühne<br><br>macosx/vout: comment use of vout_window_ReportSize as it leads to fatal mutex locking errors in the core<br><br>Commenting the function allows us to use the vout until the core is correctly fixed. This commit must be reverted before release.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"><a href="http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=adc359f6c9be9b5f232adadd8f7f4f1167c8e79a">http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=adc359f6c9be9b5f232adadd8f7f4f1167c8e79a</a><br></blockquote><hr> modules/video_output/macosx.m | 6 ++++--<br> 1 file changed, 4 insertions(+), 2 deletions(-)<br><br>diff --git a/modules/video_output/macosx.m b/modules/video_output/macosx.m<br>index 12043a9141..de85879341 100644<br>--- a/modules/video_output/macosx.m<br>+++ b/modules/video_output/macosx.m<br>@@ -246,7 +246,8 @@ static int Open (vout_display_t *vd, const vout_display_cfg_t *cfg,<br> vd->control = Control;<br> <br> /* */<br>- vout_window_ReportSize(sys->embed, fmt->i_visible_width, fmt->i_visible_height);<br>+ // FIXME: this call leads to a fatal mutex locking error in vout_ChangeDisplaySize()<br>+ // vout_window_ReportSize(sys->embed, fmt->i_visible_width, fmt->i_visible_height);<br></blockquote><br>The ReportSize is sent by the "vout window" to tell when its size has <br>been changed (by the user/system/etc). It should not be handled in the <br>"vout display" module. In the case of OS X that would be in the <br>VLCVoutView of VLCVideoOutputProvider.m or the VLCMinimalVoutWindow of <br>intf.m.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> return VLC_SUCCESS;<br> <br>@@ -644,7 +645,8 @@ static void OpenglSwap (vlc_gl_t *gl)<br> sys->cfg.display.height = bounds.size.height;<br> <br> vout_display_PlacePicture(&place, &vd->source, &sys->cfg);<br>- vout_window_ReportSize(sys->embed, bounds.size.width, bounds.size.height);<br>+ // FIXME: this call leads to a fatal mutex locking error in vout_ChangeDisplaySize()<br>+ // vout_window_ReportSize(sys->embed, bounds.size.width, bounds.size.height);<br> }<br> }<hr>vlc-commits mailing list<br>vlc-commits@videolan.org<br><a href="https://mailman.videolan.org/listinfo/vlc-commits">https://mailman.videolan.org/listinfo/vlc-commits</a><br><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>