<html><head></head><body>Hi,<br><br>Indeed, you need to include some headers. We already do that many times in the fix-ups for lack of a sane cleaner alternative.<br><br><div class="gmail_quote">Le 15 juillet 2019 10:12:02 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 2019-07-13 9:33, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Le perjantaina 12. heinäkuuta 2019, 12.43.43 EEST Steve Lhomme a écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;">On 2019-07-12 9:14, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"> Hi,<br><br> size_t and unsigned should be the same on Win32, so I don't exactly see<br> the point.<br><br> Of course, there *is* a problem on Win64, but either MingW should be fixed<br> or a systematic work-around should be used,m (e.g. #define lfind<br> lfind_size_t), otherwise the same bug will reoccur silently (only on<br> 64-bits Windows) every time lfind() is used.<br></blockquote>I can make a local fix by remapping lfind() to a local function with the<br>correct signature, but if we want to make it generic it's trickier. It<br>is used by plugins, so it either needs to be exported by the core (nope)<br>or added in compat.<br></blockquote>Ah? You can just do that in vlc_fixups.h<br><br>#ifdef _WIN64<br>static inline ... lfind_size_t(..){ lfind(...); }<br></blockquote><br>You can't do an inline calling lfind() in vlc_fixups.h unless you <br>include search.h there. I don't think it's an option.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">#define lfind lfind_size_t<br>#endif<br><br>But given that's unlikely VLC-specific problem, it's better to fix the Win64<br>port in MingW, IMO.<br><br>-- <br>レミ・デニ-クールモン<br><a href="http://www.remlab.net/">http://www.remlab.net/</a><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>