<div dir="auto">Hi, can someone review these patches?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Jul 19, 2019, 5:17 PM Rohan Rajpal <<a href="mailto:rohan17089@iiitd.ac.in">rohan17089@iiitd.ac.in</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Remove hardcoding from aspect ratio<br>
---<br>
 modules/gui/qt/qml/player/ControlButtons.qml | 5 ++---<br>
 modules/gui/qt/qml/style/VLCStyle.qml        | 2 ++<br>
 2 files changed, 4 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/modules/gui/qt/qml/player/ControlButtons.qml b/modules/gui/qt/qml/player/ControlButtons.qml<br>
index d3a672d3cd..6ce0ca971b 100644<br>
--- a/modules/gui/qt/qml/player/ControlButtons.qml<br>
+++ b/modules/gui/qt/qml/player/ControlButtons.qml<br>
@@ -394,10 +394,9 @@ Item{<br>
     Component{<br>
         id: aspectRatioDelegate<br>
         Utils.ComboBoxExt {<br>
-            id: combo<br>
             Layout.alignment: Qt.AlignVCenter<br>
-            height: 28 * scale<br>
-            width: 100 * scale<br>
+            width: VLCStyle.widthAspectRatio<br>
+            height: VLCStyle.heightAspectRatio<br>
             textRole: "display"<br>
             model: player.aspectRatio<br>
             onCurrentIndexChanged: model.toggleIndex(currentIndex)<br>
diff --git a/modules/gui/qt/qml/style/VLCStyle.qml b/modules/gui/qt/qml/style/VLCStyle.qml<br>
index bf0ca04933..971285531a 100644<br>
--- a/modules/gui/qt/qml/style/VLCStyle.qml<br>
+++ b/modules/gui/qt/qml/style/VLCStyle.qml<br>
@@ -97,6 +97,8 @@ Item {<br>
     property int widthSearchInput: 200 * scale;<br>
     property int widthSortBox: 150 * scale;<br>
     property int widthTeletext: 280 * scale;<br>
+    property int widthAspectRatio: 100 * scale;<br>
+    property int heightAspectRatio: 22 * scale;<br>
     property int heightInput: 22 * scale;<br>
<br>
     property int selectedBorder: 2<br>
-- <br>
2.17.1<br>
<br>
_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a></blockquote></div>