<div><div dir="auto"><br></div></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, 27 Jul 2019 at 5:53 PM, Marvin Scholz <<a href="mailto:epirat07@gmail.com">epirat07@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
<br>
On 27 Jul 2019, at 9:44, Roland Bewick wrote:<br>
<br>
> Hi Marvin, thanks for the reply.<br>
><br>
> On 26/07/2019 6:54 PM, Marvin Scholz wrote:<br>
>> Hi, thanks for your patch!<br>
>><br>
>> Some remarks:<br>
>><br>
>> I think in general what you want is to allow individual plugins to <br>
>> use<br>
>> the service advertisement module(s) to advertise themselves or add<br>
>> advertisements.<br>
>><br>
>> The service advertisement module can not know what to advertise and <br>
>> hardcoding<br>
>> a specific advertisement seems wrong.<br>
><br>
>><br>
>> For example what you likely want to advertise instead or in addition <br>
>> to<br>
>> _vlc._tcp.local is _http._tcp.local for the VLC web interface.<br>
><br>
> I think _vlc._tcp.local could be used to advertise any sort of VLC <br>
> interface (Whatever is being used at the time)? That way it wouldn't <br>
> conflict if you were using _http._tcp.local for some other purpose <br>
> outside of hosting VLC.<br>
><br>
<br>
This is not how these identifiers work. They are used to announce <br>
protocols, and if you want to<br>
announce the HTTP interface, that would be _http._tcp.local. You do not <br>
need to worry about any<br>
conflict here. This will even make some Browser like Safari show the <br>
discovered entries in the<br>
Browser bookmarks Bonjour section.<br>
<br>
Of course if advertising the remote control API, that could use its own <br>
protocol identifier.<br>
<br>
For a list of all registered identifiers see<br>
<a href="https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xml" rel="noreferrer" target="_blank">https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xml</a></blockquote><div dir="auto"><br></div><div dir="auto">Ok, thanks :-)</div><div dir="auto"><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><a href="https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xml" rel="noreferrer" target="_blank"></a><br>
<br>
>><br>
>> And for the address, only the module actually listening to the socket <br>
>> and<br>
>> providing whatever service you want to announce can know which <br>
>> address to<br>
>> announce, unless I misunderstand something here.<br>
>><br>
>> For example if the VLC http module only listens on v4 only, you do <br>
>> not want<br>
>> to announce the v6 address too.<br>
>><br>
>> On 24 Jul 2019, at 17:43, Roland Bewick wrote:<br>
>><br>
>>> ---<br>
>>> modules/services_discovery/microdns.c | 23 +++++++++++++++++++++++<br>
>>> 1 file changed, 23 insertions(+)<br>
>>><br>
>>> diff --git a/modules/services_discovery/microdns.c <br>
>>> b/modules/services_discovery/microdns.c<br>
>>> index ad0d2691f7..e9ff0c6380 100644<br>
>>> --- a/modules/services_discovery/microdns.c<br>
>>> +++ b/modules/services_discovery/microdns.c<br>
>>> @@ -40,6 +40,8 @@ static int OpenSD( vlc_object_t * );<br>
>>> static void CloseSD( vlc_object_t * );<br>
>>> static int OpenRD( vlc_object_t * );<br>
>>> static void CloseRD( vlc_object_t * );<br>
>>> +static int OpenSA( vlc_object_t * );<br>
>>> +static void CloseSA( vlc_object_t * );<br>
>>><br>
>>> VLC_SD_PROBE_HELPER( "microdns", N_("mDNS Network Discovery"), <br>
>>> SD_CAT_LAN )<br>
>>> VLC_RD_PROBE_HELPER( "microdns_renderer", "mDNS renderer <br>
>>> Discovery" )<br>
>>> @@ -69,6 +71,14 @@ vlc_module_begin()<br>
>>> set_callbacks( OpenRD, CloseRD )<br>
>>> add_shortcut( "mdns_renderer", "microdns_renderer" <br>
>>> )<br>
>>> VLC_RD_PROBE_SUBMODULE<br>
>>> + add_submodule() \<br>
>>> + set_description( N_( "mDNS Services Advertisement" ) <br>
>>> )<br>
>>> + set_category( CAT_ADVANCED )<br>
>>> + set_subcategory( SUBCAT_ADVANCED_NETWORK )<br>
>>> + set_capability( "services_advertisement", 0 )<br>
>>> + set_callbacks( OpenSA, CloseSA )<br>
>>> + add_shortcut( "mdns", "microdns" )<br>
>>> + VLC_RD_PROBE_SUBMODULE<br>
>>> vlc_module_end ()<br>
>>><br>
>>> static const struct<br>
>>> @@ -673,3 +683,16 @@ CloseRD( vlc_object_t *p_this )<br>
>>><br>
>>> CleanCommon( p_sys );<br>
>>> }<br>
>>> +<br>
>>> +static int<br>
>>> +OpenSA( vlc_object_t *p_obj )<br>
>>> +{<br>
>>> + msg_Dbg(p_obj, "TODO: Open service advertisement module");<br>
>>> + return VLC_SUCCESS;<br>
>>> +}<br>
>>> +<br>
>>> +static void<br>
>>> +CloseSA( vlc_object_t *p_this )<br>
>>> +{<br>
>>> + msg_Dbg(p_this, "TODO: Close service advertisement module");<br>
>>> +}<br>
>>> \ No newline at end of file<br>
>>> -- <br>
>>> 2.11.0<br>
>>><br>
>>> _______________________________________________<br>
>>> vlc-devel mailing list<br>
>>> To unsubscribe or modify your subscription options:<br>
>>> <a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
>> _______________________________________________<br>
>> vlc-devel mailing list<br>
>> To unsubscribe or modify your subscription options:<br>
>> <a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
> _______________________________________________<br>
> vlc-devel mailing list<br>
> To unsubscribe or modify your subscription options:<br>
> <a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a></blockquote></div></div>