<div dir="auto"><div>I discussed it with Pierre before adding it. Adding the settings button would make it easy to access the settings and it will look consistent with the media library. </div><div dir="auto"><br><div class="gmail_quote" dir="auto"><div dir="ltr" class="gmail_attr">On Sat, Aug 3, 2019, 12:03 AM Jean-Baptiste Kempf <<a href="mailto:jb@videolan.org">jb@videolan.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">No. Why?<br>
<br>
On Fri, Aug 2, 2019, at 20:18, Rohan Rajpal wrote:<br>
> Add the settings button to player topbar.<br>
> ---<br>
>  modules/gui/qt/qml/player/TopBar.qml | 22 +++++++++++++++++++++-<br>
>  1 file changed, 21 insertions(+), 1 deletion(-)<br>
> <br>
> diff --git a/modules/gui/qt/qml/player/TopBar.qml <br>
> b/modules/gui/qt/qml/player/TopBar.qml<br>
> index 365993dae3..7cae11e0bb 100644<br>
> --- a/modules/gui/qt/qml/player/TopBar.qml<br>
> +++ b/modules/gui/qt/qml/player/TopBar.qml<br>
> @@ -23,6 +23,7 @@ import org.videolan.vlc 0.1<br>
>  <br>
>  import "qrc:///style/"<br>
>  import "qrc:///utils/" as Utils<br>
> +import "qrc:///menus/" as Menus<br>
>  <br>
>  Utils.NavigableFocusScope{<br>
>      id: topFocusScope<br>
> @@ -77,8 +78,27 @@ Utils.NavigableFocusScope{<br>
>                              playlistWidget.gainFocus(playlistBtn)<br>
>                          }<br>
>                      }<br>
> -                    property bool acceptFocus: true<br>
> +                    KeyNavigation.right: menuBtn<br>
>                  }<br>
> +<br>
> +                Utils.IconToolButton {<br>
> +                    id: menuBtn<br>
> +                    size: VLCStyle.icon_normal<br>
> +                    text: VLCIcons.menu<br>
> +                    onClicked: {<br>
> +                        lockAutoHide = true<br>
> +                        mainMenu.openBelow(this)<br>
> +                    }<br>
> +                    property alias mainMenuExt: mainMenu<br>
> +                    Menus.MainDropdownMenu {<br>
> +                        id: mainMenu<br>
> +                        onClosed: {<br>
> +                            lockAutoHide = false<br>
> +                            menuBtn.forceActiveFocus()<br>
> +                        }<br>
> +                    }<br>
> +                }<br>
> +<br>
>              }<br>
>          }<br>
>      }<br>
> -- <br>
> 2.17.1<br>
> <br>
> _______________________________________________<br>
> vlc-devel mailing list<br>
> To unsubscribe or modify your subscription options:<br>
> <a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
<br>
-- <br>
Jean-Baptiste Kempf -  President<br>
+33 672 704 734<br>
_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a></blockquote></div></div></div>