<div dir="auto">Okay then. </div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Aug 3, 2019, 12:40 AM Jean-Baptiste Kempf <<a href="mailto:jb@videolan.org" target="_blank" rel="noreferrer">jb@videolan.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><u></u><div><div>Disagree for both places.<br></div><div><br></div><div>On Fri, Aug 2, 2019, at 20:54, Rohan Rajpal wrote:<br></div><blockquote type="cite" id="m_1279867255294915129m_-3322308004757602194qt"><div dir="auto"><div>I discussed it with Pierre before adding it. Adding the settings button would make it easy to access the settings and it will look consistent with the media library. <br></div><div dir="auto"><div><br></div><div dir="auto" class="m_1279867255294915129m_-3322308004757602194qt-gmail_quote"><div class="m_1279867255294915129m_-3322308004757602194qt-gmail_attr" dir="ltr">On Sat, Aug 3, 2019, 12:03 AM Jean-Baptiste Kempf <<a href="mailto:jb@videolan.org" rel="noreferrer noreferrer" target="_blank">jb@videolan.org</a>> wrote:<br></div><blockquote style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(204,204,204);border-left-style:solid;border-left-width:1px;padding-left:1ex" class="m_1279867255294915129m_-3322308004757602194qt-gmail_quote"><div>No. Why?<br></div><div> <br></div><div> On Fri, Aug 2, 2019, at 20:18, Rohan Rajpal wrote:<br></div><div> > Add the settings button to player topbar.<br></div><div> > ---<br></div><div> >  modules/gui/qt/qml/player/TopBar.qml | 22 +++++++++++++++++++++-<br></div><div> >  1 file changed, 21 insertions(+), 1 deletion(-)<br></div><div> > <br></div><div> > diff --git a/modules/gui/qt/qml/player/TopBar.qml <br></div><div> > b/modules/gui/qt/qml/player/TopBar.qml<br></div><div> > index 365993dae3..7cae11e0bb 100644<br></div><div> > --- a/modules/gui/qt/qml/player/TopBar.qml<br></div><div> > +++ b/modules/gui/qt/qml/player/TopBar.qml<br></div><div> > @@ -23,6 +23,7 @@ import org.videolan.vlc 0.1<br></div><div> >  <br></div><div> >  import "qrc:///style/"<br></div><div> >  import "qrc:///utils/" as Utils<br></div><div> > +import "qrc:///menus/" as Menus<br></div><div> >  <br></div><div> >  Utils.NavigableFocusScope{<br></div><div> >      id: topFocusScope<br></div><div> > @@ -77,8 +78,27 @@ Utils.NavigableFocusScope{<br></div><div> >                              playlistWidget.gainFocus(playlistBtn)<br></div><div> >                          }<br></div><div> >                      }<br></div><div> > -                    property bool acceptFocus: true<br></div><div> > +                    KeyNavigation.right: menuBtn<br></div><div> >                  }<br></div><div> > +<br></div><div> > +                Utils.IconToolButton {<br></div><div> > +                    id: menuBtn<br></div><div> > +                    size: VLCStyle.icon_normal<br></div><div> > +                    text: VLCIcons.menu<br></div><div> > +                    onClicked: {<br></div><div> > +                        lockAutoHide = true<br></div><div> > +                        mainMenu.openBelow(this)<br></div><div> > +                    }<br></div><div> > +                    property alias mainMenuExt: mainMenu<br></div><div> > +                    Menus.MainDropdownMenu {<br></div><div> > +                        id: mainMenu<br></div><div> > +                        onClosed: {<br></div><div> > +                            lockAutoHide = false<br></div><div> > +                            menuBtn.forceActiveFocus()<br></div><div> > +                        }<br></div><div> > +                    }<br></div><div> > +                }<br></div><div> > +<br></div><div> >              }<br></div><div> >          }<br></div><div> >      }<br></div><div> > -- <br></div><div> > 2.17.1<br></div><div> > <br></div><div> > _______________________________________________<br></div><div> > vlc-devel mailing list<br></div><div> > To unsubscribe or modify your subscription options:<br></div><div> > <a rel="noreferrer noreferrer noreferrer noreferrer" href="https://mailman.videolan.org/listinfo/vlc-devel" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div><div> <br></div><div> -- <br></div><div> Jean-Baptiste Kempf -  President<br></div><div> +33 672 704 734<br></div><div> _______________________________________________<br></div><div> vlc-devel mailing list<br></div><div> To unsubscribe or modify your subscription options:<br></div><div> <a rel="noreferrer noreferrer noreferrer noreferrer" href="https://mailman.videolan.org/listinfo/vlc-devel" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote></div></div></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote><div><br></div><div id="m_1279867255294915129m_-3322308004757602194sig60240713"><div class="m_1279867255294915129m_-3322308004757602194signature">--<br></div><div class="m_1279867255294915129m_-3322308004757602194signature">Jean-Baptiste Kempf -  President<br></div><div class="m_1279867255294915129m_-3322308004757602194signature">+33 672 704 734<br></div><div class="m_1279867255294915129m_-3322308004757602194signature"> <br></div><div class="m_1279867255294915129m_-3322308004757602194signature"><br></div></div><div><br></div></div>_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer noreferrer noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a></blockquote></div>