<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Yes, that's mostly why i've submitted this, else I just would have wrote a dummy callback. I also have a use case, a "fake" offscreen window. A window module setting up buffers instead of window.<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>De :</b> vlc-devel <vlc-devel-bounces@videolan.org> de la part de Steve Lhomme <robux4@ycbcr.xyz><br>
<b>Envoyé :</b> mardi 20 août 2019 12:45<br>
<b>À :</b> vlc-devel@videolan.org <vlc-devel@videolan.org><br>
<b>Objet :</b> Re: [vlc-devel] [PATCH] vout window: check for NULL on owner's callback resized</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">On 2019-08-20 12:34, Rémi Denis-Courmont wrote:<br>
> Hi,<br>
> <br>
> What's the use case for a window whose size is ignored??<br>
<br>
At least it would be consistent with the documentation (you wrote):<br>
<br>
* This callback function (if non-NULL) is invoked when the windowing<br>
* system changes the window size.<br>
<br>
> Le 20 août 2019 12:38:59 GMT+03:00, "Maxime ..." <mmeisson@outlook.fr> a écrit :<br>
>> ---<br>
>> include/vlc_vout_window.h | 3 ++-<br>
>> 1 file changed, 2 insertions(+), 1 deletion(-)<br>
>><br>
>> diff --git a/include/vlc_vout_window.h b/include/vlc_vout_window.h<br>
>> index 4e0f3c13a9..9638d882c2 100644<br>
>> --- a/include/vlc_vout_window.h<br>
>> +++ b/include/vlc_vout_window.h<br>
>> @@ -543,7 +543,8 @@ void vout_window_Disable(vout_window_t *window);<br>
>> static inline void vout_window_ReportSize(vout_window_t *window,<br>
>> unsigned width, unsigned height)<br>
>> {<br>
>> - window->owner.cbs->resized(window, width, height);<br>
>> + if (window->owner.cbs->resized != NULL)<br>
>> + window->owner.cbs->resized(window, width, height);<br>
>> }<br>
>><br>
>> /**<br>
>> -- <br>
>> 2.17.1<br>
>><br>
>> _______________________________________________<br>
>> vlc-devel mailing list<br>
>> To unsubscribe or modify your subscription options:<br>
>> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
> <br>
> -- <br>
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.<br>
> <br>
> <br>
> _______________________________________________<br>
> vlc-devel mailing list<br>
> To unsubscribe or modify your subscription options:<br>
> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
> <br>
_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></div>
</span></font></div>
</body>
</html>