<html><head></head><body>Hi,<br><br>While passing NULL for %s is unequivocally UB, I don't see how this patch fixes any format overflow, TBH.<br><br><br><br><div class="gmail_quote">Le 5 septembre 2019 14:37:24 GMT+03:00, Alexandre Janniaux <ajanni@videolabs.io> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail"><hr> modules/stream_out/mosaic_bridge.c | 5 +++--<br> 1 file changed, 3 insertions(+), 2 deletions(-)<br><br>diff --git a/modules/stream_out/mosaic_bridge.c b/modules/stream_out/mosaic_bridge.c<br>index fa5d00c259..71c33090ef 100644<br>--- a/modules/stream_out/mosaic_bridge.c<br>+++ b/modules/stream_out/mosaic_bridge.c<br>@@ -386,7 +386,7 @@ static void *Add( sout_stream_t *p_stream, const es_format_t *p_fmt )<br> };<br><br> psz_chain = var_GetNonEmptyString( p_stream, CFG_PREFIX "vfilter" );<br>- msg_Dbg( p_stream, "psz_chain: %s", psz_chain );<br>+ msg_Dbg( p_stream, "psz_chain: '%s'", psz_chain ? psz_chain : "");<br> if( psz_chain )<br> {<br> filter_owner_t owner = {<br>@@ -581,7 +581,8 @@ inline static int video_update_format_decoder( decoder_t *p_dec )<br> {<br> // update the filter after the format changed/is known<br> char *psz_chain = var_GetNonEmptyString( p_owner->p_stream, CFG_PREFIX "vfilter" );<br>- msg_Dbg( p_owner->p_stream, "update filter: %s", psz_chain );<br>+ msg_Dbg( p_owner->p_stream, "update filter: '%s'",<br>+ psz_chain ? psz_chain : "" );<br> if( psz_chain )<br> {<br> es_format_t fmt;<br>--<br>2.23.0<hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>