<html><head></head><body>Hi,<br><br>Excuse me? How does this change macOS code?<br><br><div class="gmail_quote">Le 23 septembre 2019 13:44:54 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 2019-09-23 11:28, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">I am sad to see that you are still attacking me after other people have done the same thing, trivial changes to the core, and then claim the contrary.<br></blockquote><br>I know I pushed 054296854082e70580d3bcf85d77d7ebc3f6e800 which is just a <br>comment change and I proposed in July (in a big patchset).<br><br>As for the trivial part, given you change macOS code and we all know you <br>didn't verify it on that platform, it would be at least good to ask devs <br>on that platform that the changes are OK. For example Apple may decide <br>to (not) support something and later change its mind.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">I don't have advice on code review from somebody that knowingly merged a broken UI rework in spite of objections, and still is inhibiting the development process 6 months later.<br><br>Le 23 septembre 2019 11:23:43 GMT+03:00, Thomas Guillem <thomas@gllm.fr> a écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> Hello,<br><br> I'm sad to see that this didn't went through the mailing list. I think<br> that every one now is doing this extra effort.<br><br> Nevertheless, I'm OK with this set.<br><br> On Sat, Sep 21, 2019, at 11:49, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">vlc | branch: master | Rémi Denis-Courmont <remi@remlab.net> | Sat<br></blockquote>Sep<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"> 21 11:57:19 2019 +0300| [95041019b09a5ecd8c5343721a136b349590be92] |<br> committer: Rémi Denis-Courmont<br><br> posix: rely on F_DUPFD_CLOEXEC<br><br> This was added in POSIX.2008 and thus missing on MacOS < 10.7.<br> But those old versions are no longer supported since VLC 3.0.<br><br></blockquote><a href="http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=95041019b09a5ecd8c5343721a136b349590be92">http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=95041019b09a5ecd8c5343721a136b349590be92</a><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"><hr> src/posix/filesystem.c | 7 -------<br> 1 file changed, 7 deletions(-)<br><br> diff --git a/src/posix/filesystem.c b/src/posix/filesystem.c<br> index 2ac9c1187e..0ba1a37957 100644<br> --- a/src/posix/filesystem.c<br> +++ b/src/posix/filesystem.c<br> @@ -185,14 +185,7 @@ char *vlc_getcwd (void)<br> <br> int vlc_dup (int oldfd)<br> {<br> -#ifdef F_DUPFD_CLOEXEC<br> return fcntl (oldfd, F_DUPFD_CLOEXEC, 0);<br> -#else<br> - int newfd = dup (oldfd);<br> - if (newfd != -1)<br> - vlc_cloexec(oldfd);<br> - return newfd;<br> -#endif<br> }<br> <br> int vlc_pipe (int fds[2])<hr> vlc-commits mailing list<br> vlc-commits@videolan.org<br> <a href="https://mailman.videolan.org/listinfo/vlc-commits">https://mailman.videolan.org/listinfo/vlc-commits</a><br><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.<hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>