<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}
p.MsoNormal,p.MsoNoSpacing{margin:0}
p.MsoNormal,p.MsoNoSpacing{margin:0}
p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div><br></div><div><br></div><div>On Mon, Sep 23, 2019, at 11:28, Rémi Denis-Courmont wrote:<br></div><blockquote id="qt" type="cite"><div>I am sad to see that you are still attacking me after other people have done the same thing, trivial changes to the core, and then claim the contrary.<br></div></blockquote><div><br></div><div>I told the same thing to everyone, privately or publicly. I will continue to ask that same thing until we move to gitlab and are all forced to ho through MR.<br></div><div><br></div><div>These changes don't look that trivial to me. <br></div><div><br></div><blockquote id="qt" type="cite"><div><br></div><div>I don't have advice on code review from somebody that knowingly merged a broken UI rework in spite of objections, and still is inhibiting the development process 6 months later<br></div><div><br></div><div class="qt-gmail_quote"><div>Le 23 septembre 2019 11:23:43 GMT+03:00, Thomas Guillem <thomas@gllm.fr> a écrit :<br></div><blockquote class="qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204, 204, 204);padding-left:1ex;"><pre class="qt-k9mail"><div>Hello,<br></div><div><br></div><div>I'm sad to see that this didn't went through the mailing list. I think that every one now is doing this extra effort.<br></div><div><br></div><div>Nevertheless, I'm OK with this set.<br></div><div><br></div><div>On Sat, Sep 21, 2019, at 11:49, Rémi Denis-Courmont wrote:<br></div><blockquote class="qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(114, 159, 207);padding-left:1ex;"><div>vlc | branch: master | Rémi Denis-Courmont <remi@remlab.net> | Sat Sep <br></div><div>21 11:57:19 2019 +0300| [95041019b09a5ecd8c5343721a136b349590be92] | <br></div><div>committer: Rémi Denis-Courmont<br></div><div><br></div><div>posix: rely on F_DUPFD_CLOEXEC<br></div><div><br></div><div>This was added in POSIX.2008 and thus missing on MacOS < 10.7.<br></div><div>But those old versions are no longer supported since VLC 3.0.<br></div><div><br></div><blockquote class="qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(173, 127, 168);padding-left:1ex;"><a href="http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=95041019b09a5ecd8c5343721a136b349590be92">http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=95041019b09a5ecd8c5343721a136b349590be92</a><br></blockquote><div><hr> src/posix/filesystem.c | 7 -------<br></div><div> 1 file changed, 7 deletions(-)<br></div><div> <br></div><div> diff --git a/src/posix/filesystem.c b/src/posix/filesystem.c<br></div><div> index 2ac9c1187e..0ba1a37957 100644<br></div><div> --- a/src/posix/filesystem.c<br></div><div> +++ b/src/posix/filesystem.c<br></div><div> @@ -185,14 +185,7 @@ char *vlc_getcwd (void)<br></div><div> <br></div><div> int vlc_dup (int oldfd)<br></div><div> {<br></div><div> -#ifdef F_DUPFD_CLOEXEC<br></div><div> return fcntl (oldfd, F_DUPFD_CLOEXEC, 0);<br></div><div> -#else<br></div><div> - int newfd = dup (oldfd);<br></div><div> - if (newfd != -1)<br></div><div> - vlc_cloexec(oldfd);<br></div><div> - return newfd;<br></div><div> -#endif<br></div><div> }<br></div><div> <br></div><div> int vlc_pipe (int fds[2])<hr> vlc-commits mailing list<br></div><div> vlc-commits@videolan.org<br></div><div> <a href="https://mailman.videolan.org/listinfo/vlc-commits">https://mailman.videolan.org/listinfo/vlc-commits</a><br></div><div><br></div></blockquote><div><hr>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></pre></blockquote></div><div><br></div><div>-- <br></div><div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></body></html>