<html><head></head><body>Steve, all,<br><br>For the reference, I reckon that the TC agreed unanimously to have mandatory reviews for API changes, including both plugin and LibVLC API sets. Roughly if you need to change anything in include/ directory other than documentation.<br><br>There were inconclusive discussions whether to extend that to non-trivial core and bindings (src/, bin/, lib/) changes as well.<br><br><div class="gmail_quote">Le 24 septembre 2019 10:26:36 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 2019-09-24 8:30, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">And most of who anyway?! Denis, Felix and myself have all objected to mandatory reviews on more or less the same basis. David did not express an opinion that I'd be aware of.<br><br>Most people within VideoLabs maybe. But even there, it does not look to me that François wants mandatory reviews either, and Steve seems very ambivalent about it.<br></blockquote><br>I'll speak for myself. I thought it was agreed upon that code in the <br>core and libvlc should be reviewed before merging. Maybe I <br>misunderstood. I did not even know the Technical Committee had <br>discussions on that, left alone any decision taken.<br><br>I think this would be a good thing, especially to avoid breaking other <br>platforms we don't test on. For bigger patchset it's also good to have <br>different opinion on an algorithm or some technical choice. For example <br>the work on decoder device/video context is benefiting a lot from that.<br><br>In the end there are hardly a case where a patch cannot wait a day or <br>two before being merged. Even (and especially) security issue patches <br>that must be rushed in a release should be reviewed first.<br><br>I sometimes rush some on code I maintain and noone will rely review/test <br>the code and that would bloke more incoming patches. For example the <br>D3D/NVDEC decoder device. But that's outside of the core/libvlc.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">So I'm counting 2 (you and Hugo) against 4 of the main VLC committers here. So much for "most".<br><br>Le 24 septembre 2019 01:32:36 GMT+03:00, Thomas Guillem <thomas@gllm.fr> a écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"><br> On Mon, Sep 23, 2019, at 22:57, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">Le maanantaina 23. syyskuuta 2019, 23.26.20 EEST Thomas Guillem a<br></blockquote>écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #fcaf3e; padding-left: 1ex;">On Mon, Sep 23, 2019, at 18:20, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #e9b96e; padding-left: 1ex;">So me in public and everybody else privately. Same difference.<br></blockquote></blockquote></blockquote>That's<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #fcaf3e; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #e9b96e; padding-left: 1ex;">still<br></blockquote>I remember telling François and steve on this ML.<br></blockquote>All I see is asking François if he can send patches for review in the<br></blockquote>future.<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">Noting from Steve at all.<br></blockquote> I speak to Steve regularly, and we do video conf so I might have tel<br> him this way. To be honest I don't remember.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">How convenient to remember something that did not happen (sources:<br></blockquote>vlc-devel<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"> archives).<br><br> Well, if that's it, then I remember that the committee did not<br></blockquote>approve any<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">review mandate. So I am going to flatly ignore all your comments on<br></blockquote>mandatory<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">reviews until the commitee or the GA passes a resolution on the topic<br></blockquote> Why so much tension ? Could we work together again ? It worked quite<br> well in the past few months, every one were respecting each others and<br> each others reviews. It can't work if you ignore me or if I ignore you<br> since we are both main VLC developers...<br><br> I know for a fact that most people want mandatory review. I think it<br> will be voted during the next VDD. In the meantime, I would really love<br> that all core commits go through the ML. I really apprecited your extra<br> effort recently when you went throught the ML. And I always try to send<br> good reviews.<br><br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"> -- <br> Реми Дёни-Курмон<br> <a href="http://www.remlab.net/">http://www.remlab.net/</a><hr> vlc-devel mailing list<br> To unsubscribe or modify your subscription options:<br> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.<hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>