<html><head></head><body>Yes and so this patch is not just harmful, but it's redundant with code reviews.<br><br><div class="gmail_quote">Le 2 octobre 2019 13:26:22 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 2019-10-02 12:18, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Next people will add incorrect manual casts to silence the errors <br>instead of fixing them properly. Not a good idea.<br></blockquote><br>We have code review for that.<br>Using a cast to silence an error is no different than using a cast to <br>silence a warning. In both case it's wrong and we shouldn't do it.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Le 2 octobre 2019 13:14:14 GMT+03:00, Romain Vimont <rom1v@videolabs.io> <br>a écrit :<hr> configure.ac | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br><br> diff --git a/configure.ac b/configure.ac<br> index 210b4ca537..2fa70daf22 100644<br> --- a/configure.ac<br> +++ b/configure.ac<br> @@ -988,7 +988,7 @@ dnl<br> AX_APPEND_COMPILE_FLAGS([-Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wvolatile-register-var -Wformat -Wformat-security -Wduplicated-branches -Wduplicated-cond], [CFLAGS])<br> AX_APPEND_COMPILE_FLAGS([-Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wvolatile-register-var -Wformat -Wformat-security -Wduplicated-branches -Wduplicated-cond], [CXXFLAGS])<br> <br> -AX_APPEND_COMPILE_FLAGS([-Wbad-function-cast -Wwrite-strings -Wmissing-prototypes -Werror-implicit-function-declaration -Winit-self -Wlogical-op -Wshadow=local -Wmultistatement-macros], [CFLAGS])<br> +AX_APPEND_COMPILE_FLAGS([-Wbad-function-cast -Wwrite-strings -Wmissing-prototypes -Werror-implicit-function-declaration -Winit-self -Wlogical-op -Wshadow=local -Wmultistatement-macros -Werror=incompatible-pointer-types], [CFLAGS])<br> AX_APPEND_COMPILE_FLAGS([-pipe], [CFLAGS])<br> <br> dnl<br><br><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser <br>ma brièveté.<hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>