<html><head></head><body>I'm referring to a time when we had fewer platforms, fewer compiler versions and fewer contribs yes. In other words, warning as error is an even worse idea now.<br><br>We only do it for missing declaration because it caused a lot of actual bugs on 64-bits. I can't see that problem with bad casts.<br><br><div class="gmail_quote">Le 2 octobre 2019 14:23:01 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 2019-10-02 13:17, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">So you take responsibility for guaranteeing that all headers of all <br>underlying libraries and SDK will never cause cast warnings?<br></blockquote><br>Absolutely.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">We already discussed this, and everybody except Pierre d'H. was against, <br>for good reasons.<br></blockquote><br>You must be talking about a time we didn't have much contribs or patches <br>for contribs or C code we relied on wasn't clean. I think the quality of <br>C code we use/produce has greatly improved. Maybe dirty contribs have <br>also been removed.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Le 2 octobre 2019 14:03:32 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> a <br>écrit :<br><br> On 2019-10-02 13:02, Rémi Denis-Courmont wrote:<br><br> Yes and last I checked, VLC includes libavutil header files.<br><br><br> I do include libavutil and have no problem with this compiler flag.<br><br> Le 2 octobre 2019 13:27:38 GMT+03:00, Steve Lhomme<br> <robux4@ycbcr.xyz> a<br> écrit :<br><br> On 2019-10-02 12:20, Rémi Denis-Courmont wrote:<br><br> And VLC depends on some libraries that rely on bad casts, notably<br> libavutil (heap helpers).<br><br><br> This is the configure script of VLC, not the contribs. I use<br> this flag<br> all day long on Win32 and Linux builds with no issue. That enables<br> spotting errors like the AMT one very quickly.<br><br> Le 2 octobre 2019 13:18:30 GMT+03:00, "Rémi Denis-Courmont"<br> <remi@remlab.net> a écrit :<br><br> Next people will add incorrect manual casts to silence the errors<br> instead of fixing them properly. Not a good idea.<br><br> Le 2 octobre 2019 13:14:14 GMT+03:00, Romain Vimont<br> <rom1v@videolabs.io> a écrit :<hr> configure.ac | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br><br> diff --git a/configure.ac b/configure.ac<br> index 210b4ca537..2fa70daf22 100644<br> --- a/configure.ac<br> +++ b/configure.ac<br> @@ -988,7 +988,7 @@ dnl<br> AX_APPEND_COMPILE_FLAGS([-Wall -Wextra -Wsign-compare -Wundef<br> -Wpointer-arith -Wvolatile-register-var -Wformat<br> -Wformat-security -Wduplicated-branches -Wduplicated-cond],<br> [CFLAGS])<br> AX_APPEND_COMPILE_FLAGS([-Wall -Wextra -Wsign-compare -Wundef<br> -Wpointer-arith -Wvolatile-register-var -Wformat<br> -Wformat-security -Wduplicated-branches -Wduplicated-cond],<br> [CXXFLAGS])<br><br> -AX_APPEND_COMPILE_FLAGS([-Wbad-function-cast -Wwrite-strings<br> -Wmissing-prototypes -Werror-implicit-function-declaration<br> -Winit-self -Wlogical-op -Wshadow=local<br> -Wmultistatement-macros], [CFLAGS])<br> +AX_APPEND_COMPILE_FLAGS([-Wbad-function-cast -Wwrite-strings<br> -Wmissing-prototypes -Werror-implicit-function-declaration<br> -Winit-self -Wlogical-op -Wshadow=local -Wmultistatement-macros<br> -Werror=incompatible-pointer-types], [CFLAGS])<br> AX_APPEND_COMPILE_FLAGS([-pipe], [CFLAGS])<br><br> dnl<br><br><br> -- <br> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez<br> excuser<br> ma brièveté.<hr> vlc-devel mailing list<br> To unsubscribe or modify your subscription options:<br> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><hr> vlc-devel mailing list<br> To unsubscribe or modify your subscription options:<br> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br><br><br> -- <br> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez<br> excuser<br> ma brièveté.<hr> vlc-devel mailing list<br> To unsubscribe or modify your subscription options:<br> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><hr> vlc-devel mailing list<br> To unsubscribe or modify your subscription options:<br> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br><br><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser <br>ma brièveté.<hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>