<html><head></head><body>As far as I can tell, this makes broken assumptions that will break playback in some cases.<br><br><div class="gmail_quote">Le 3 octobre 2019 10:37:52 GMT+03:00, Thomas Guillem <thomas@gllm.fr> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">Any last words ?<br><br>On Tue, Oct 1, 2019, at 14:33, Thomas Guillem wrote:<br>> <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><br>On Mon, Sep 30, 2019, at 21:52, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;">Le torstaina 26. syyskuuta 2019, 17.38.11 EEST Thomas Guillem a écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">The highest decoder latency of all clocks will be used to setup the initial<br>dejitter delay.<br></blockquote>We cannot generally, or even usually, measure the decoder latency.<br></blockquote>I agree, but we the avcodec module can guess it, according to its <br>thread_count and fps. It's not perfect but it's sufficient to fix all <br>problems we have with low fps samples (when you have a CPU with lot of <br>cores).<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;">On top of that, even if we could measure it, it does not even seem to mean <br>anything if the set of active ES changes, or if for any reason the ES are not <br>in sync (input slaves, multiple RTP sessions, etc).<br></blockquote>Yes, this is why this function can fail. vlc_clock_SetDecoderLatency() <br>won't be able to handle a big delay ( > 300ms = file-caching) if a <br>video track is enabled midstream. Everything is handled in avcodec:<br>cf. <br><a href="https://code.videolan.org/tguillem/vlc/commit/38206d600fe2eba78a72cc4b19749db087b6a408">https://code.videolan.org/tguillem/vlc/commit/38206d600fe2eba78a72cc4b19749db087b6a408</a><br><br>This is not a perfect solution but it will fix most issues we have with <br>normal media samples (video starting near the audio).<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;">-- <br>レミ・デニ-クールモン<br><a href="http://www.remlab.net/">http://www.remlab.net/</a><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>