<html><head></head><body>Hi,<br><br>This is not technical debt as I understand the concept. This is a coding style that does not suit your taste.<br><br>Not to deny that there's plenty of technical debt to be repaid in the code base.<br><br><div class="gmail_quote">Le 11 octobre 2019 10:15:32 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 2019-10-11 9:02, Thomas Guillem wrote:<br>> <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">On Fri, Oct 11, 2019, at 08:50, Steve Lhomme wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;">On 2019-10-10 18:26, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">Le torstaina 10. lokakuuta 2019, 18.32.34 EEST Thomas Guillem a écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #fcaf3e; padding-left: 1ex;"> It is just a question of taste. The actual code is OK to me.<br><br> When I develop, I tend to do like this current code instead of creating an<br> extra variable.<br><br> I have nothing about this way or another but I don't think this commit is<br> really needed.<br></blockquote>I dislike both ways, but I can't really think of a third option.<br></blockquote> I prefer balanced locks. It's easier to read and less prone to mistakes.<br> In a small function like that it's easy to spot, but if it even grows<br> we're getting closer and closer to a possible issue.<br><br> If there we kept the old value we used, we could tell if we really need<br> to send the message and save the extra bool (but then we need 2<br> unsigned). It may make sense to avoid sending unnecessary messages to<br> the window anyway.<br></blockquote>I don't mind if you do that in any new code, but I don't like changing a perfectly fine code for personal taste (if it's not accepted by everyone).<br>There is a lot of code in VLC where I don't like the coding style, but I keep it that way in order to not create too much git noise.<br></blockquote><br>And that's why we keep carrying this huge technical debt.<hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>