<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div>"fullscreen output nul-terminated identifier,"<br></div><div><br></div><div>That looks like an id for the screen, like Gabriel is using.<br></div><div><br></div><div>On Tue, Oct 15, 2019, at 08:53, Rémi Denis-Courmont wrote:<br></div><blockquote type="cite" id="qt"><div>By window manager I mean what is commonly called window manager in the context of GUI.<br></div><div><br></div><div>And the ID parameter is the same as in the owner callbacks, which are documented.<br></div><div><br></div><div class="qt-gmail_quote"><div>Le 13 octobre 2019 17:15:29 GMT+03:00, Gabriel Luci <github@luci.ca> a écrit :<br></div><blockquote style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="qt-gmail_quote"><div dir="ltr"><div>By window manager, do you mean at vout_ChangeFullscreen (src\video_output\video_output.c:390)? That's where it starts passing a handle to the window rather than the vout.<br></div><div><br></div><div>What was that id parameter originally intended for? I noticed it was changed from a bool to a char* by you last year, but never used.<br></div></div><div><br></div><div class="qt-gmail_quote"><div class="qt-gmail_attr" dir="ltr">On Sun, Oct 13, 2019 at 3:18 AM Rémi Denis-Courmont <<a href="mailto:remi@remlab.net">remi@remlab.net</a>> wrote:<br></div><blockquote style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="qt-gmail_quote"><div>Le sunnuntaina 13. lokakuuta 2019, 6.58.29 EEST Gabriel Luci a écrit :<br></div><div> > Pass the setting as the id parameter to vout_ChangeFullscreen()<br></div><div> > ---<br></div><div> > src/video_output/vout_intf.c | 6 +++++-<br></div><div> > 1 file changed, 5 insertions(+), 1 deletion(-)<br></div><div> > <br></div><div> > diff --git a/src/video_output/vout_intf.c b/src/video_output/vout_intf.c<br></div><div> > index ce50616fc9..9a0120fb4d 100644<br></div><div> > --- a/src/video_output/vout_intf.c<br></div><div> > +++ b/src/video_output/vout_intf.c<br></div><div> > @@ -566,7 +566,11 @@ static int FullscreenCallback( vlc_object_t *p_this,<br></div><div> > char const *psz_cmd, (void)psz_cmd; (void) oldval; (void)p_data;<br></div><div> > <br></div><div> > if( newval.b_bool )<br></div><div> > - vout_ChangeFullscreen(p_vout, NULL);<br></div><div> > + {<br></div><div> > + char *psz_fullscreen_monitor = var_InheritString( p_vout,<br></div><div> > "fullscreen-monitor" ); + vout_ChangeFullscreen(p_vout,<br></div><div> > psz_fullscreen_monitor);<br></div><div> > + free( psz_fullscreen_monitor );<br></div><div> > + }<br></div><div> > else<br></div><div> > vout_ChangeWindowed(p_vout);<br></div><div> > return VLC_SUCCESS;<br></div><div> <br></div><div> This breaks the API definition and intended semantics of passing NULL there - <br></div><div> let the window manager pick the most suitable default.<br></div><div> <br></div><div> -- <br></div><div> 雷米‧德尼-库尔蒙<br></div><div> <a rel="noreferrer" href="http://www.remlab.net/">http://www.remlab.net/</a><br></div><div> <br></div><div> <br></div><div> <br></div><div> _______________________________________________<br></div><div> vlc-devel mailing list<br></div><div> To unsubscribe or modify your subscription options:<br></div><div> <a rel="noreferrer" href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote></div></blockquote></div><div><br></div><div>-- <br></div><div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></body></html>