<div dir="ltr">Thanks for this precise information. I wished I could copy it into the wiki, but I unfortunately can't create an account in the wiki ("You do not have permission to create this user account, for the following reason: The action you have requested is limited to users in the group: Administrators.")<div><br></div><div>A final question before I proceed: am I allowed to edit the AUTHORS file, to boastfully add a line there? :-) Or is this restricted to lead maintainers only?</div><div><br></div><div>Thanks</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Le mer. 16 oct. 2019 à 19:42, Alexandre Janniaux <<a href="mailto:ajanni@videolabs.io">ajanni@videolabs.io</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br>
<br>
Yes, this is documented, but yes, this is an incomplete,<br>
confusing not well-maintained documentation. It will<br>
probably move to a different platform to ease maintenance<br>
later.<br>
<br>
Here are the documentation links:<br>
+ <a href="https://wiki.videolan.org/Git/" rel="noreferrer" target="_blank">https://wiki.videolan.org/Git/</a><br>
+ <a href="https://wiki.videolan.org/Sending_Patches_VLC/" rel="noreferrer" target="_blank">https://wiki.videolan.org/Sending_Patches_VLC/</a><br>
<br>
What you probably want to do is the following:<br>
+ squash the commit when it is relevant, so that each commit<br>
is an atomic non-breaking change to the codebase.<br>
+ git fetch origin && git rebase origin/master, given that<br>
origin is the VLC's main repository.<br>
+ git format-patch --cover-letter --reroll-count=2 \<br>
--output-directory somefolder origin/master<br>
(I've let the verbose option so you can check what they<br>
are doing)<br>
+ edit the cover letter and check the different patches in<br>
the somefolder directory.<br>
+ git send-email --no-chain-reply-to [potentially<br>
--in-reply-to=<some Message-id>] \<br>
--to <a href="mailto:vlc-devel@videolan.org" target="_blank">vlc-devel@videolan.org</a><br>
<br>
When you'll get some ease at using send-mail, you can<br>
shortcut everything (especially for little patch) using:<br>
<br>
git send-email --to <a href="mailto:vlc-devel@videolan.org" target="_blank">vlc-devel@videolan.org</a><br>
[-<number of commit you want to send> OR<br>
origin/master OR<br>
fromcommit..tocommit]<br>
[--reroll-count=2 ]<br>
--compose<br>
--no-chain-reply-to<br>
[--in-reply-to=<message-id> ]<br>
<br>
Note that you can send email to anyone, not just the mailing<br>
list, so you can actually test with your own inbox to check<br>
how it is working. It is also a very convenient way to send<br>
patches/some code to someone or receive some, especially if<br>
the receiver has the mail environment to handle this<br>
efficiently. For example with neomutt, I can just use `t` to<br>
select the patches and then write ;|git am<enter> to apply<br>
all selected patches to my current worktree. One could also<br>
just bind a key for this, and I guess thunderbird can allow<br>
the same sort of thing but never tried.<br>
<br>
I hope everything is clear for you and that I didn't write<br>
mistakes,<br>
<br>
Regards,<br>
--<br>
Alexandre Janniaux<br>
Videolabs<br>
<br>
On Wed, Oct 16, 2019 at 11:53:17AM +0200, Jérôme Froissart wrote:<br>
> Thanks for your reply.<br>
> Just to be sure that I will not jeopardize (again) the mailing list, could<br>
> you confirm I understood correctly? I should now :<br>
> - squash the main commit and the change I have made after you reviewed it<br>
> - send a fresh (that does not reply to anything) patchset to the mailing<br>
> list<br>
> - append a "(v2)" to the title of the cover letter of this fresh patchset<br>
><br>
> Is that correct?<br>
> Thanks for the help (maybe this workflow could be described on your wiki,<br>
> for people like me who are contributing for the first time via a mailing<br>
> list? Or maybe it is written already, but I failed to find it?)<br>
><br>
> Jérôme<br>
><br>
><br>
> On Tue, 15 Oct 2019, 14:15 Alexandre Janniaux, <<a href="mailto:ajanni@videolabs.io" target="_blank">ajanni@videolabs.io</a>> wrote:<br>
><br>
> > Hi,<br>
> ><br>
> > This looks correct and a good idea, but you will need to<br>
> > send clean patches.<br>
> ><br>
> > > I am new to using mailing lists, so I hope I replied correctly and did<br>
> > not mess with the --in-reply-to option.<br>
> > > Also, I am sending a single "code review" commit, is that all right for<br>
> > you? Or do you rather prefer one commit that squashes this correction with<br>
> > the previous proposed patch?<br>
> ><br>
> > We usually prefer proper commit and use git range-diff with<br>
> > the previous version to compare, so the patch can be merged<br>
> > without resend.<br>
> ><br>
> > Also, you have to put the GPLv2 license for Qt files, as<br>
> > the module is itself in GPLv2. You can grab it from any<br>
> > file from the Qt module.<br>
> ><br>
> > Regards,<br>
> > --<br>
> > Alexandre Janniaux<br>
> > Videolabs<br>
> ><br>
> > On Mon, Oct 14, 2019 at 10:59:06AM +0200, Jérôme Froissart wrote:<br>
> > > ---<br>
> > > You are right, I forgot to call config_StringEscape.<br>
> > > Here is a correction patch. Note that it escapes quotes and slashes, it<br>
> > does not percent-encode special chars. I guess it is the correct behaviour<br>
> > (since it was used in the implementation I removed), but please tell me if<br>
> > some percent-escaping should take place as well.<br>
> > ><br>
> > > I am new to using mailing lists, so I hope I replied correctly and did<br>
> > not mess with the --in-reply-to option.<br>
> > > Also, I am sending a single "code review" commit, is that all right for<br>
> > you? Or do you rather prefer one commit that squashes this correction with<br>
> > the previous proposed patch?<br>
> > ><br>
> > > Thanks<br>
> > ><br>
> > ><br>
> > > modules/gui/qt/util/soutmrl.cpp | 7 ++++++-<br>
> > > modules/gui/qt/util/soutmrl.hpp | 2 +-<br>
> > > 2 files changed, 7 insertions(+), 2 deletions(-)<br>
> > ><br>
> > > diff --git a/modules/gui/qt/util/soutmrl.cpp<br>
> > b/modules/gui/qt/util/soutmrl.cpp<br>
> > > index 90615c6c86..6dc316ec42 100644<br>
> > > --- a/modules/gui/qt/util/soutmrl.cpp<br>
> > > +++ b/modules/gui/qt/util/soutmrl.cpp<br>
> > > @@ -14,7 +14,12 @@ QString MrlModule::to_string() const<br>
> > > s += it->first;<br>
> > > if( it->second.to_string().compare("") != 0 )<br>
> > > {<br>
> > > - s += "=" + it->second.to_string();<br>
> > > + char *psz = config_StringEscape(<br>
> > qtu(it->second.to_string()) );<br>
> > > + if( psz )<br>
> > > + {<br>
> > > + s += "=" + qfu( psz );<br>
> > > + free( psz );<br>
> > > + }<br>
> > > }<br>
> > > ++it;<br>
> > > if( it != options.end() )<br>
> > > diff --git a/modules/gui/qt/util/soutmrl.hpp<br>
> > b/modules/gui/qt/util/soutmrl.hpp<br>
> > > index 2e92e9064e..b18016fef3 100644<br>
> > > --- a/modules/gui/qt/util/soutmrl.hpp<br>
> > > +++ b/modules/gui/qt/util/soutmrl.hpp<br>
> > > @@ -90,7 +90,7 @@ private:<br>
> > > /// - any number of key(=value) pairs<br>
> > > /// values can be nested modules<br>
> > > ///<br>
> > > -/// Example of MRL:<br>
> > HEADERmodule1{a,b=val}:module2:module3{opt,arg=1,stuff=nestedModule{subkey=subvalue}}<br>
> > > +/// Example of MRL:<br>
> > HEADERmodule1{a,b=val}:module2:module3{opt,arg=\"value with automatically<br>
> > escaped quotes\",stuff=nestedModule{subkey=subvalue}}<br>
> > > class SoutMrl<br>
> > > {<br>
> > > public:<br>
> > > --<br>
> > > 2.20.1<br>
> > ><br>
> > > _______________________________________________<br>
> > > vlc-devel mailing list<br>
> > > To unsubscribe or modify your subscription options:<br>
> > > <a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
> > _______________________________________________<br>
> > vlc-devel mailing list<br>
> > To unsubscribe or modify your subscription options:<br>
> > <a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
<br>
> _______________________________________________<br>
> vlc-devel mailing list<br>
> To unsubscribe or modify your subscription options:<br>
> <a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
<br>
_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a></blockquote></div>