<div dir="auto"><div>Hi,<div dir="auto"><br></div><div dir="auto">It fixes HW playback of my phone videos (Google Pixel 3).</div><div dir="auto">I couldn't find this constant in VLC MP4 parser code either, my guess is that is is converted from the fourcc. It is deprecated in ffmpeg headers so I guess that on this side it just treats YUVJ420P and YUV420P exactly the same, and probably convert one to the other before it hits the vaapi code.</div><div dir="auto">Here is a sample:</div><div dir="auto"><a href="https://photos.app.goo.gl/wZ8PsRKzp4HirS9S9" target="_blank" rel="noreferrer">https://photos.app.goo.gl/wZ8PsRKzp4HirS9S9</a><br></div><div dir="auto"><br></div><div dir="auto">Mathieu</div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Le jeu. 17 oct. 2019 à 08:07, Steve Lhomme <<a href="mailto:robux4@ycbcr.xyz" rel="noreferrer noreferrer noreferrer" target="_blank">robux4@ycbcr.xyz</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
Looking at the ffmpeg code I see no reference to AV_PIX_FMT_YUVJ420P in <br>
the VAAPI code. What does this patch do ?<br>
<br>
You can find the list of output supported by ffmpeg here:<br>
<a href="https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/vaapi_decode.c#L237" rel="noreferrer noreferrer noreferrer noreferrer noreferrer" target="_blank">https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/vaapi_decode.c#L237</a><br>
<br>
Notice there is no YUVJ420P and I couldn't see anywhere it changed from <br>
YUV420P when the source is full range.<br>
<br>
On 2019-10-17 0:36, Mathieu Velten wrote:<br>
> ---<br>
> modules/codec/avcodec/va.c | 1 +<br>
> 1 file changed, 1 insertion(+)<br>
> <br>
> diff --git a/modules/codec/avcodec/va.c b/modules/codec/avcodec/va.c<br>
> index 7d4660012e..05831232d2 100644<br>
> --- a/modules/codec/avcodec/va.c<br>
> +++ b/modules/codec/avcodec/va.c<br>
> @@ -40,6 +40,7 @@ vlc_fourcc_t vlc_va_GetChroma(enum PixelFormat hwfmt, enum PixelFormat swfmt)<br>
> case AV_PIX_FMT_VAAPI_VLD:<br>
> switch (swfmt)<br>
> {<br>
> + case AV_PIX_FMT_YUVJ420P:<br>
> case AV_PIX_FMT_YUV420P:<br>
> return VLC_CODEC_VAAPI_420;<br>
> case AV_PIX_FMT_YUV420P10LE:<br>
> -- <br>
> 2.21.0<br>
> <br>
> _______________________________________________<br>
> vlc-devel mailing list<br>
> To unsubscribe or modify your subscription options:<br>
> <a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer noreferrer noreferrer noreferrer noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
> <br>
_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer noreferrer noreferrer noreferrer noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a></blockquote></div>
</div></div>