<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div>Indeed, it should be done only if GL_OES_EGL_image is not defined.<br></div><div><br></div><div>cf. gl headers on my distrib:<br></div><div><br></div><div>#ifndef GL_OES_EGL_image<br></div><div>#define GL_OES_EGL_image 1<br></div><div>#ifdef GL_GLEXT_PROTOTYPES<br></div><div>GLAPI void APIENTRY glEGLImageTargetTexture2DOES (GLenum target, GLeglImageOES image);<br></div><div>GLAPI void APIENTRY glEGLImageTargetRenderbufferStorageOES (GLenum target, GLeglImageOES image);<br></div><div>#endif<br></div><div>typedef void (APIENTRYP PFNGLEGLIMAGETARGETTEXTURE2DOESPROC) (GLenum target, GLeglImageOES image);<br></div><div>typedef void (APIENTRYP PFNGLEGLIMAGETARGETRENDERBUFFERSTORAGEOESPROC) (GLenum target, GLeglImageOES image);<br></div><div>#endif<br></div><div><br></div><div>On Mon, Oct 21, 2019, at 13:52, Rémi Denis-Courmont wrote:<br></div><blockquote type="cite" id="qt"><div>This will make compilation fail on older or other EGL dev headers.<br></div><div><br></div><div class="qt-gmail_quote"><div>Le 19 octobre 2019 15:57:07 GMT+03:00, Alexandre Janniaux <ajanni@videolabs.io> a écrit :<br></div><blockquote style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="qt-gmail_quote"><pre class="qt-k9mail"><div>OES_EGL_image extension is an OpenGL ES extension and the typedef might<br></div><div>not be available on EGL or OpenGL extension headers.<br></div><div><br></div><div>As of October 19 2019, it makes compilation fail on my ArchLinux<br></div><div>because they are not defined anymore in the headers included.<hr> modules/video_output/opengl/converter_vaapi.c | 6 ++++++<br></div><div> 1 file changed, 6 insertions(+)<br></div><div><br></div><div>diff --git a/modules/video_output/opengl/converter_vaapi.c b/modules/video_output/opengl/converter_vaapi.c<br></div><div>index 36e3e974ec..1246b3bdb4 100644<br></div><div>--- a/modules/video_output/opengl/converter_vaapi.c<br></div><div>+++ b/modules/video_output/opengl/converter_vaapi.c<br></div><div>@@ -35,6 +35,12 @@<br></div><div> #include "converter.h"<br></div><div> #include "../../hw/vaapi/vlc_vaapi.h"<br></div><div><br></div><div>+/* From <a href="https://www.khronos.org/registry/OpenGL/extensions/OES/OES_EGL_image.txt">https://www.khronos.org/registry/OpenGL/extensions/OES/OES_EGL_image.txt</a><br></div><div>+ * The extension is an OpenGL ES extension but can (and usually is) available on<br></div><div>+ * OpenGL implementations. */<br></div><div>+typedef void *GLeglImageOES;<br></div><div>+typedef void (*PFNGLEGLIMAGETARGETTEXTURE2DOESPROC)(GLenum target, GLeglImageOES image);<br></div><div>+<br></div><div> struct priv<br></div><div> {<br></div><div> VADisplay vadpy;<br></div><div>--<br></div><div>2.23.0<hr>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></pre></blockquote></div><div><br></div><div>-- <br></div><div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></body></html>