<html><head></head><body>I don't think the misdesigns of the other libavcodec hwaccel are a good reference here. VDPAU hwaccel was designed properly so that the app needs not add codec-specific handling. Not sure about DxVA, but there are no reasons why this would not be possible for VAAPI too, other than that nobody cared to think the design through.<br><br><div class="gmail_quote">Le 25 octobre 2019 08:45:16 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 2019-10-24 21:21, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Le torstaina 24. lokakuuta 2019, 17.20.22 EEST Steve Lhomme a écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;">It gives one when it should be 8. Other codecs seem to be OK.<br></blockquote>Isn't that a bug in upstream libavcodec ?<br></blockquote><br>It might be. But the ffmpeg hardware handlers and ours except for VDPAU <br>rely on the codec ID rather than the AVContext refs to find the number <br>of surfaces needed.<br><br>At least for VP9 it gives a value of 2 even though 8 are needed. <br>Software decoding works but it might be because it can allocate more <br>pictures than originally expected.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Forcing 2 refs does not seem to match the patch description.<br></blockquote><br>This also follows other implementations where the default amount needed <br>is 2 (MPEG1/2, VC1, for example).<hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>