<html><head></head><body>I agree that exclusive mode is necessary. It's the negotiation around it that seems wrong (plus the fact that the resampler is not disabled).<br><br><div class="gmail_quote">Le 28 octobre 2019 13:41:54 GMT+02:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 2019-10-28 11:45, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Hi,<br><br>Based on the forum requests, I think people want bit exact on Windows, <br>not exclusive mode on Thomas Guillem's hardware.<br><br>Bit exact means no filters, no resampling, no remixing, and no format <br>conversion, except maybe exact up-conversion. It does not, as such, mean <br>to get audio out with WASAPI exclusive mode.<br></blockquote><br>There's still the OS mixer. If it's bypassed by the exclusive mode, <br>that's the only way to really get bit exact output.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">And it makes no sense to duplicate encoder functionality.<br><br>Le 28 octobre 2019 11:20:40 GMT+02:00, Thomas Guillem <thomas@gllm.fr> a <br>écrit :<br><br><br> On Mon, Oct 28, 2019, at 10:01, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> Hi,<br><br> Patch 4 is triplicating in one aout what belongs in OS HAL and VLC<br> encoders. Are you going to write an MPEG Audio encoder in WASAPI<br> just because some devices only accept that, also?<br></blockquote> If users are asking for it, yes, but it won't be top priority at all<br> (unless there is huge use case suddenly).<br><br> I added 24bit support because the first sound card I tested for the<br> wasapi exclusive work was only accepting 24bit.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;">Patch 5 is doing the opposite of what people want to use exclusive<br>mode for: implicitly add VLC conversion filters instead of<br>disabling them.<br></blockquote> OK. Maybe, the "wasapi-exclusive" option should be a global option<br> (can be handled by Windows and Mac, don't know for pulse). That way,<br> we can disable all audio filtering if enabled.<br><br> Then, let's say the input is 16bit and the soundcard is 24bit. What<br> should we done in that case ? I assumed that it would be always OK<br> to convert up to 24bit. Maybe we can add an option to this<br> "exclusive" mode to prevent any conversion.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> I don't think either of them is a step in the right direction.<br><br> Le 28 octobre 2019 10:25:02 GMT+02:00, Thomas Guillem<br> <thomas@gllm.fr> a écrit :<br><br><br> On Fri, Oct 25, 2019, at 18:15, Rémi Denis-Courmont wrote:<br><br> Le perjantaina 25. lokakuuta 2019, 15.45.16 EEST Alexandre<br> Janniaux a écrit :<br><br> Hi,<br><br> To be honest, when the main answer is "it was decided<br> decades ago", I do feel it's a great secret wisdom.<br><br> That's not what I wrote, and that just means it's obvious<br> enough that there's<br> no point reopening the topic.<br><br> Thomas's patch seems to make sense though, as a lot of<br> audio softwares are implementing it. There are also<br> probably some different use cases for exclusive mode when<br> using VLC in a different use case than the home multimedia<br> player.<br><br> I don't see how the patchset is useful. I've seen requests<br> for PCM pass-<br> through, which sort-of makes sense with a digital output,<br> but that's not at<br> all what this patchset does.<br><br> PCM pass-through means that you set exclusive mode and<br> force the DAC format to<br> match the sample rate, channel map of the decoded input,<br> and pick the wire<br> sample format, practically signed 16-bits. This patch does<br> almost the exact<br> opposite: negotiate the rate, map and bit depth.<br><br><br> My patch is good step toward this direction.<br> It will first try the input format, but fallback to other<br> possible compatible format. We can use a 3 value options:<br> disabled, FORCED, ON if format compatible.<br> The main problem is that VLC can insert audio-filter like time<br> stretch that could alterate the audio/format.<br><br> -- <br> Реми Дёни-Курмон<br> <a href="http://www.remlab.net/">http://www.remlab.net/</a><hr> vlc-devel mailing list<br> To unsubscribe or modify your subscription options:<br> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><hr> vlc-devel mailing list<br> To unsubscribe or modify your subscription options:<br> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br><br><br> -- <br> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez<br> excuser ma brièveté.<hr> vlc-devel mailing list<br> To unsubscribe or modify your subscription options:<br> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser <br>ma brièveté.<hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>