<html><head></head><body>Yeah. This patch does not look right.<br><br>Don't confuse unitialised (a bug) with maybe unitialised (often not a bug).<br><br><div class="gmail_quote">Le 28 octobre 2019 15:24:06 GMT+09:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 2019-10-26 14:17, Alexandre Janniaux wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><hr>  test/modules/packetizer/hxxx.c | 4 ++++<br>  1 file changed, 4 insertions(+)<br><br>diff --git a/test/modules/packetizer/hxxx.c b/test/modules/packetizer/hxxx.c<br>index 6a7767570f..8cae9bfd86 100644<br>--- a/test/modules/packetizer/hxxx.c<br>+++ b/test/modules/packetizer/hxxx.c<br>@@ -62,6 +62,10 @@ static void test_iterators( const uint8_t *p_ab, size_t i_ab, /* AnnexB */<br>          int i_nal = 0;<br>          while(b1 && b2)<br>          {<br>+            /* hxxx_*_iterate_next can potentially not set these pointers. */<br></blockquote><br>Yes, but in this case b1/b2 is false and the value is not used.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">+            p_start_ab = NULL;<br>+            p_start_prefix = NULL;<br>+<br>              b1 = hxxx_annexb_iterate_next( &it_ab, &p_start_ab, &i_size_ab );<br>              b2 = hxxx_iterate_next( &it_prefix, &p_start_prefix, &i_size_prefix );<br>              printf("NAL %d ", i_nal++);<br>-- <br>2.23.0<hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>