<html><head></head><body>And? That's not what caused the current skins issue. This is literally just removing one useless layer of indirection - nonfunctional change.<br><br><div class="gmail_quote">Le 3 décembre 2019 10:50:00 GMT+02:00, Alexandre Janniaux <ajanni@videolabs.io> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">Hi,<br><br>I was talking about this:<br><br>commit 64fcc45a149bb553b59e6ed902edd6bc57a09ac5<br>Refs: 4.0.0-dev-5623-g64fcc45a14<br>Author: Rémi Denis-Courmont <remi@remlab.net><br>AuthorDate: Sat Dec 1 17:54:41 2018 +0200<br>Commit: Rémi Denis-Courmont <remi@remlab.net><br>CommitDate: Sun Dec 2 19:57:32 2018 +0200<br><br> qt: move window code<br><br> This removes one layer of function calls. This also removes the old<br> check for interface destroyed before window, which would not work<br> properly, since most vout displays cannot cope with their window going<br> away asynchronously.<br><br>I don't mean that it is wrong, but that I never saw a<br>correct implementation done with the core.<br><br>Regards,<br>--<br>Alexandre Janniaux<br>Videolabs<br><br><br>On Tue, Dec 03, 2019 at 09:40:57AM +0200, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> I did not remove my and Laurent's hacks there. There were removed by the people who merged the last playlist rewrote and/or the half-baked Qt rewrite.<br><br> Le 3 décembre 2019 01:03:52 GMT+02:00, Alexandre Janniaux <ajanni@videolabs.io> a écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;">Hi,<br><br>On Mon, Dec 02, 2019 at 07:05:13PM +0200, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">Le maanantaina 2. joulukuuta 2019, 10.20.15 EET Alexandre Janniaux a<br></blockquote>écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #fcaf3e; padding-left: 1ex;"> Hi,<br><br> Actually stopping the playlist wont kill the video output<br> module, only killing the input resource, meaning releasing<br> the vlc_player will do.<br><br> However, player and playlist might be used by multiple<br> control interface and this problem is only a concern for<br> the one providing the vout_window. Hence I believe it must<br> be solved by the mechanism providing the window instead of<br> relying on a much wider API like playlist and player.<br></blockquote>By the same logic, it's only a problem for the window provider of an<br>interface, not the stand-alone ones, and thus it should be handled by<br></blockquote>the<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">interface. Obvious logical flaw is obvious.<br></blockquote>I'm sorry, I tried, but I really don't understand neither what<br>you call obvious nor your example. Can you provide details ?<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">Besides, technically there is already a way to handle this. It's just<br></blockquote>that<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">interface implementors cannot be bothered (UI frameworks make it<br></blockquote>hard) to<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">handle the window being allocated before the interface, or<br></blockquote>deallocated after<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">the interface. At the core level, everything is already in place for<br></blockquote>this.<br><br>Which one ? The issue has been fighting here for years with<br>hacks that you removed because they were hacks. I never saw<br>an interface working with this design in the ML archive.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">And I really don't see how you can fix that in the video window code,<br></blockquote>which is<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">the most obvious but not the only symptomatic case. This really is a<br></blockquote>problem<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">between the playlist and the main interfaces.<br></blockquote>Why ? I started working on this month ago and while I'm not<br>full time on this, I see only a simple problem: interface and<br>window share a common context, so you cannot kill the<br>interface resource before the window. Either you make the<br>interface resource refcounted and living in the wild while<br>there still are window using those, or you make correct<br>resource management and manage the lifetime correctly.<br><br>I detailed the issue, suggested a solution and have half a PoC.<br>What is the issue that you're trying to solve and how?<br><br>Regards,<br>--<br>Alexandre Janniaux<br>Videolabs<hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote>--<br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.<br></blockquote><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>