<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}
p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div><br></div><div>On Fri, Dec 6, 2019, at 18:59, Rémi Denis-Courmont wrote:<br></div><blockquote id="qt" type="cite"><div>This makes zero sense. <br></div></blockquote><div><br></div><div>Could you please avoid hurtful sentence in the future ? Same for the "B.S." sent last week on the skins2 mail.<br></div><div>I sent this patch knowing that it needed a discussion. I don't need to be remained how bad my proposal is.<br></div><div>What I would like instead is the opinion of everyone about the 3 possibilities of the "audio-bitexact" mode.<br></div><div><br></div><blockquote id="qt" type="cite"><div>If you do bit exact in aout, you don't have a filter chain.<br></div></blockquote><div><br></div><div><div>I could have used a boolean for the "audio-bitexact" option. In that case, indeed, there is no need to use a filters chain.</div><div><br></div><div>But what about --audio-bitexact with an aout specific exclusive mode ?<br></div><div>People won't be able to play mp3 with these 2 modes enabled (FL32 decoder). Is that wanted ? And what about S16N when you have a S24N or S32N soundcard ? <br></div><div><br></div><div>This is why I added a tertiary option: "convert", that will remove all filters except the one converter that could be needed to adapt to the output format.<br></div><div><br></div><div>Using "on"/"off" for "audio-bitexact" seems dubious. That is why I would prefer using something like the following:<br></div><div><br></div><div>--audio-bitexact=0: default<br></div><div>--audio-bitexact=1: on (with one converter)<br></div><div>--audio-bitexact=2: strict (without any converters)<br></div><div><br></div><div>The big question is: should we remove 1 or 2 ?<br></div><div>If we remove 1, then this option need to be used only by people that master their input and output.<br></div><div>If we remove 2, advanced users won't be able to detect that their whole input/output chain is really bitexact.<br></div><div><div><br></div></div></div><blockquote id="qt" type="cite"><div><br></div><div>And if you do bit exact in transcode, then you don't have a decoder and an encoder so you even *can't* have a filter chain (this has worked fine for years already).<br></div></blockquote><div><br></div><blockquote id="qt" type="cite"><div><br></div><div class="qt-gmail_quote"><div>Le 4 décembre 2019 09:54:06 GMT+01:00, Thomas Guillem <thomas@gllm.fr> a écrit :<br></div><blockquote class="qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><pre class="qt-k9mail"><div><br></div><div>On Mon, Dec 2, 2019, at 18:07, Rémi Denis-Courmont wrote:<br></div><blockquote class="qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div>Le keskiviikkona 27. marraskuuta 2019, 10.44.53 EET Thomas Guillem a écrit :<br></div><blockquote class="qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(173, 127, 168);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div>On Tue, Nov 26, 2019, at 19:03, Rémi Denis-Courmont wrote:<br></div><blockquote class="qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(138, 226, 52);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div>Le tiistaina 26. marraskuuta 2019, 17.31.24 EET Thomas Guillem a écrit :<br></div><blockquote class="qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(252, 175, 62);border-left-style:solid;border-left-width:1px;padding-left:1ex;">src/audio_output/filters.c | 87 +++++++++++++++++++-------------<br></blockquote><div>The checks do not belong there.<br></div></blockquote><div>Which checks ?<br></div></blockquote><div>The added checks in filters.c<br></div></blockquote><div><br></div><div>Indeed, it's used outside the aout. Every other users could also specify the bit excact mode via aout_filters_cfg_t.<br></div><div>Ideally, we would move some var bool check to aout_filters_cfg_t too.<br></div><div><br></div><div>> <br></div><blockquote class="qt-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div>-- <br></div><div>雷米‧德尼-库尔蒙<br></div><div><a href="http://www.remlab.net/">http://www.remlab.net/</a><hr>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote><div><hr>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></pre></blockquote></div><div><br></div><div>-- <br></div><div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></body></html>