<html><head></head><body>We've already had this discussion, and this kind of change was already rejected.<br><br>Warnings as errors are screwing anybody using a configuration different from CI's. Packagers have consistently rejected warning as errors.<br><br>By your argument, basically all warnings should be errors. You're basically denying the concept of warnings.<br><br><div class="gmail_quote">Le 18 décembre 2019 11:16:24 GMT+02:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 2019-12-18 10:03, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">That's exactly what's wrong. They're warnings and they should stay that way.<br></blockquote><br>I disagree.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">You're welcome to attend to them.<br></blockquote><br>I can't compile on macOS, iOS or Android. Should I check the full logs <br>of each MR I'm doing on Gitlab to see if somewhere there's a change I <br>did that is doing something bad ? Will you ?<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Le 18 décembre 2019 10:13:42 GMT+02:00, Steve Lhomme <robux4@ycbcr.xyz> <br>a écrit :<br><br> On 2019-12-17 18:20, Rémi Denis-Courmont wrote:<br><br> Le tiistaina 17. joulukuuta 2019, 16.09.28 EET Steve Lhomme a<br> écrit :<br><br> This avoid using pointers of different types. It may lead to<br> serious issues<br> in the code so rather than a warning, it should be<br> avoided/fixed.<br><br> This will raise warnings in harmless cases of implicit<br> conversions. Some of<br><br><br> It's not adding any warning. It's turning existing (unattended) warnings<br> into errors.<br><br> those might not be easily fixable - coming from external headers.<br><br><br> True, but it seems we have none of these on Windows, Linux (and macOS<br> I'm told). I'd rather not allow new code using dirty pointer casts, even<br> from external library headers.<hr> vlc-devel mailing list<br> To unsubscribe or modify your subscription options:<br> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br><br><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser <br>ma brièveté.<br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>