<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jan 9, 2020 at 5:50 PM Alexandre Janniaux <<a href="mailto:ajanni@videolabs.io">ajanni@videolabs.io</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br>
<br>
On Thu, Jan 09, 2020 at 10:35:23AM +0100, Steve Lhomme wrote:<br>
> On 2020-01-09 10:28, Alexandre Janniaux wrote:<br>
> > Hi,<br>
> ><br>
> > According to documentation, vlc_player_vout_HoldAll can<br>
> > return NULL and thus vouts must be checked before usage.<br>
><br>
> In that case the size is 0 so it won't have any impact.<br>
<br>
Unfortunately the documentation doesn't tell so, it might<br>
be a good addition if we consider this behaviour to be the<br>
correct one.<br>
<br></blockquote><div>I checked and only the addition of the first line </div><div>var_SetChecked(player, name, type, val);</div><div>would do the job.</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
><br>
> > I'm not sure setting variable on all vouts is a correct fix<br>
> > for the issue you are mentioning. In particular, if you<br>
> > enable a visualization with a video, or have a video with<br>
> > multiple video track, you'll get the two vout in<br>
> > fullscreen.<br>
> ><br>
> > The fix is probably in the hotkey module instead IMHO.<br>
> ><br>
> > Regards,<br>
> > --<br>
> > Alexandre Janniaux<br>
> > Videolabs<br>
> ><br>
> > On Thu, Jan 09, 2020 at 12:20:40AM +0530, <a href="mailto:vvaakshay@gmail.com" target="_blank">vvaakshay@gmail.com</a> wrote:<br>
> > > From: akshayaky <<a href="mailto:akymaster007@gmail.com" target="_blank">akymaster007@gmail.com</a>><br>
> > ><br>
> > > this commit fixes:<br>
> > >     -the fullscreen hotkey not exiting fullscreen<br>
> > >     -wallpaper mode hotkey not disabling wallpaper mode<br>
> > ><br>
> > > this commit issue #22418<br>
> > > ---<br>
> > >   src/player/vout.c | 13 ++++++++++---<br>
> > >   1 file changed, 10 insertions(+), 3 deletions(-)<br>
> > ><br>
> > > diff --git a/src/player/vout.c b/src/player/vout.c<br>
> > > index b28599288f..4ba7b1c89c 100644<br>
> > > --- a/src/player/vout.c<br>
> > > +++ b/src/player/vout.c<br>
> > > @@ -157,9 +157,16 @@ static void<br>
> > >   vlc_player_vout_SetVar(vlc_player_t *player, const char *name, int type,<br>
> > >                          vlc_value_t val)<br>
> > >   {<br>
> > > -    vout_thread_t *vout = vlc_player_vout_Hold(player);<br>
> > > -    var_SetChecked(vout, name, type, val);<br>
> > > -    vout_Release(vout);<br>
> > > +    var_SetChecked(player, name, type, val);<br>
> > > +<br>
> > > +    size_t count;<br>
> > > +    vout_thread_t **vouts = vlc_player_vout_HoldAll(player, &count);<br>
> > > +    for (size_t i = 0; i < count; i++)<br>
> > > +    {<br>
> > > +        var_SetChecked(vouts[i], name, type, val);<br>
> > > +        vout_Release(vouts[i]);<br>
> > > +    }<br>
> > > +    free(vouts);<br>
> > >   }<br>
> > ><br>
> > ><br>
> > > --<br>
> > > 2.17.1<br>
> > ><br>
> > > _______________________________________________<br>
> > > vlc-devel mailing list<br>
> > > To unsubscribe or modify your subscription options:<br>
> > > <a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
> > _______________________________________________<br>
> > vlc-devel mailing list<br>
> > To unsubscribe or modify your subscription options:<br>
> > <a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
> ><br>
> _______________________________________________<br>
> vlc-devel mailing list<br>
> To unsubscribe or modify your subscription options:<br>
> <a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a></blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr">Regards,<div>Akshay V</div><div><a href="http://github.com/akshayaky" target="_blank">GitHub</a> | Amrita Vishwa Vidyapeetham<br></div></div></div></div></div></div>