<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div><br></div><div>On Fri, Jan 10, 2020, at 16:36, Akshay V wrote:<br></div><blockquote type="cite" id="qt"><div dir="ltr"><div dir="ltr"><br></div><div><br></div><div class="qt-gmail_quote"><div class="qt-gmail_attr" dir="ltr">On Fri, Jan 10, 2020 at 5:43 PM Thomas Guillem <<a href="mailto:thomas@gllm.fr">thomas@gllm.fr</a>> wrote:<br></div><blockquote style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="qt-gmail_quote"><div><u></u><br></div><div><div>Alexandre, ideally we would like to avoid variables to control vouts, but it's not done yet.<br></div><div>So, in the meantime we should continue to use variables.<br></div><div><br></div><div>Akshay, you spotted the problem, about the vout/player var_Set mismatch. I think the correct way to fix this issue is to fix the vlc_player_vout_IsFullscreen() function. This function should return the state of the first vout (via vlc_player_vout_Hold()) instead of the player state.<br></div><div>Same for vlc_player_vout_IsWallpaperModeEnabled().<br></div><div><br></div><div>You could also remove<br></div><div><br></div><div> /* vout variables */<br></div><div> VAR_CREATE("fullscreen", VLC_VAR_BOOL | VLC_VAR_DOINHERIT);<br></div><div> VAR_CREATE("video-on-top", VLC_VAR_BOOL | VLC_VAR_DOINHERIT);<br></div><div> VAR_CREATE("video-wallpaper", VLC_VAR_BOOL | VLC_VAR_DOINHERIT);<br></div><div><br></div><div>in src/player/player.c<br></div><div><br></div></div></blockquote><div>should the removal of the vout variables and the updating the functions be in a single commit or not and if in two commits should this be in a single patch file?<br></div></div></div></blockquote><div><br></div><div>You should do it in 2 commit into 2 separate patches.<br></div><div><br></div><blockquote type="cite" id="qt"><div dir="ltr"><div><br></div><div>-- <br></div><div class="qt-gmail_signature" dir="ltr"><div dir="ltr"><div><div dir="ltr"><div>Regards,<br></div><div>Akshay V<br></div><div><a href="http://github.com/akshayaky">GitHub</a> | Amrita Vishwa Vidyapeetham<br></div></div></div></div></div></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></body></html>