<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div>Alexandre, ideally we would like to avoid variables to control vouts, but it's not done yet.<br></div><div>So, in the meantime we should continue to use variables.<br></div><div><br></div><div>Akshay, you spotted the problem, about the vout/player var_Set mismatch. I think the correct way to fix this issue is to fix the vlc_player_vout_IsFullscreen() function. This function should return the state of the first vout (via vlc_player_vout_Hold()) instead of the player state.<br></div><div>Same for vlc_player_vout_IsWallpaperModeEnabled().<br></div><div><br></div><div>You could also remove<br></div><div><br></div><div> /* vout variables */<br></div><div> VAR_CREATE("fullscreen", VLC_VAR_BOOL | VLC_VAR_DOINHERIT);<br></div><div> VAR_CREATE("video-on-top", VLC_VAR_BOOL | VLC_VAR_DOINHERIT);<br></div><div> VAR_CREATE("video-wallpaper", VLC_VAR_BOOL | VLC_VAR_DOINHERIT);<br></div><div><br></div><div>in src/player/player.c<br></div><div><br></div><div>On Thu, Jan 9, 2020, at 17:05, Akshay V wrote:<br></div><blockquote type="cite" id="qt"><div dir="ltr"><div dir="ltr"><br></div><div><br></div><div class="qt-gmail_quote"><div class="qt-gmail_attr" dir="ltr">On Thu, Jan 9, 2020 at 6:26 PM Alexandre Janniaux <<a href="mailto:ajanni@videolabs.io">ajanni@videolabs.io</a>> wrote:<br></div><blockquote style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="qt-gmail_quote"><div>Hi,<br></div><div> On Thu, Jan 09, 2020 at 05:55:23PM +0530, Akshay V wrote:<br></div><div> <br></div><div> > I checked and only the addition of the first line<br></div><div> > var_SetChecked(player, name, type, val);<br></div><div> > would do the job.<br></div><div> <br></div><div> I mean that you're not supposed to use variables to control<br></div><div> the video pipeline anymore in 4.0, and they are other<br></div><div> helpers out there like the following:<br></div><div> <br></div><div> <a rel="noreferrer" href="https://www.videolan.org/developers/vlc/doc/doxygen/html/group__vlc__player____vout.html#ga08a37f0e393d951493856b94cc9323f7">https://www.videolan.org/developers/vlc/doc/doxygen/html/group__vlc__player____vout.html#ga08a37f0e393d951493856b94cc9323f7</a><br></div><div> <br></div></blockquote><div>What do mean by this link? vlc_player_vout_SetFullscreen() calls vlc_player_vout_SetVar() function for execution. <span style="background-color:rgb(30, 30, 30)" class="highlight"><span style="color:rgb(220, 220, 170)" class="colour"><span style="font-family:"Droid Sans Mono", monospace, monospace, "Droid Sans Fallback"" class="font"><span style="font-size:14px" class="size"></span></span></span></span><br></div><div> <br></div><blockquote style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="qt-gmail_quote"><div>If those helpers are not doing what you want, or if they<br></div><div> are not used instead of variables, that is the issue you'll<br></div><div> likely want to solve instead of setting a variable on every<br></div><div> vout available, which will break other things.<br></div><div> <br></div><div> I hope this is clearer.<br></div><div> <br></div><div> Regards,<br></div><div> --<br></div><div> Alexandre Janniaux<br></div><div> Videolabs<br></div><div> _______________________________________________<br></div><div> vlc-devel mailing list<br></div><div> To unsubscribe or modify your subscription options:<br></div><div> <a rel="noreferrer" href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote></div><div><br></div><div><br></div><div>-- <br></div><div class="qt-gmail_signature" dir="ltr"><div dir="ltr"><div><div dir="ltr"><div>Regards,<br></div><div>Akshay V<br></div><div><a href="http://github.com/akshayaky">GitHub</a> | Amrita Vishwa Vidyapeetham<br></div></div></div></div></div></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></body></html>