<!doctype html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body>Hi,<br><br>Do we fail the player creation if the vout creation fails? That's news to me.<br><br><div class="gmail_quote">Le 13 janvier 2020 11:26:20 GMT+02:00, Thomas Guillem <thomas@gllm.fr> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><br></div><div><br></div><div>On Sat, Jan 11, 2020, at 04:04, Rémi Denis-Courmont wrote:<br></div><blockquote type="cite" id="qt"><div>Doesn't this crash if there's no vout for whatever reason (such as headless)?<br></div></blockquote><div><br></div><div>No, there is always a dummy vout, that we way, clients can always setup vout variables, and the real vout will inherit from it.<br></div><div><br></div><div>You already told me that you didn't like this "hack" in the past. But I would like to keep it until we rework the vout external API (for for 4.0). <br></div><div><br></div><blockquote type="cite" id="qt"><div><br></div><div class="qt-gmail_quote"><div>Le 11 janvier 2020 00:40:01 GMT+09:00, vvaakshay@gmail.com a écrit :<br></div><blockquote style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="qt-gmail_quote"><pre class="qt-k9mail"><div>From: akshayaky <akymaster007@gmail.com><br></div><div><br></div><div>now the player returns state of the first vout instead of player state<br></div><div><br></div><div>this commit fixes:<br></div><div> -the fullscreen hotkey not exiting fullscreen<br></div><div> -wallpaper mode hotkey not disabling wallpaper mode<br></div><div><br></div><div>this commit fixes issue #22418<hr> src/player/vout.c | 6 ++++--<br></div><div> 1 file changed, 4 insertions(+), 2 deletions(-)<br></div><div><br></div><div>diff --git a/src/player/vout.c b/src/player/vout.c<br></div><div>index b28599288f..a8af445026 100644<br></div><div>--- a/src/player/vout.c<br></div><div>+++ b/src/player/vout.c<br></div><div>@@ -100,7 +100,8 @@ vlc_player_vout_RemoveListener(vlc_player_t *player,<br></div><div> bool<br></div><div> vlc_player_vout_IsFullscreen(vlc_player_t *player)<br></div><div> {<br></div><div>- return var_GetBool(player, "fullscreen");<br></div><div>+ vout_thread_t *vout = vlc_player_vout_Hold(player);<br></div><div>+ return var_GetBool(vout, "fullscreen");<br></div><div> }<br></div><div> <br></div><div> static int<br></div><div>@@ -185,7 +186,8 @@ vlc_player_vout_SetFullscreen(vlc_player_t *player, bool enabled)<br></div><div> bool<br></div><div> vlc_player_vout_IsWallpaperModeEnabled(vlc_player_t *player)<br></div><div> {<br></div><div>- return var_GetBool(player, "video-wallpaper");<br></div><div>+ vout_thread_t *vout = vlc_player_vout_Hold(player);<br></div><div>+ return var_GetBool(vout, "fullscreen");<br></div><div> }<br></div><div> <br></div><div> void<br></div></pre></blockquote></div><div><br></div><div>-- <br></div><div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>