<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div>Hello,<br></div><div><br></div><div>I responded on your previous patch. Sorry for my late reply.<br></div><div><br></div><div>Regards,<br></div><div>Thomas<br></div><div><br></div><div>On Mon, Jan 13, 2020, at 19:23, Farid HAMMANE wrote:<br></div><blockquote type="cite" id="qt"><div dir="ltr"><p style="margin: 0cm 0cm 8pt; line-height: 107%;" class="qt-MsoNormal"><span style="font-family:"Calibri", sans-serif" class="font"><span style="font-size:11pt" class="size"><span lang="EN-US">Hello,</span></span></span><br></p><p style="margin: 0cm 0cm 8pt; line-height: 107%;" class="qt-MsoNormal"><span style="font-family:"Calibri", sans-serif" class="font"><span style="font-size:11pt" class="size"><span lang="EN-US"></span></span></span><br></p><p style="margin: 0cm 0cm 8pt; line-height: 107%;" class="qt-MsoNormal"><span style="font-family:"Calibri", sans-serif" class="font"><span style="font-size:11pt" class="size">If this patch is ok for you, could you please apply it? I have another patch waiting that depends on it (support of multiple formats).</span></span><br></p><p style="margin: 0cm 0cm 8pt; line-height: 107%;" class="qt-MsoNormal"><span style="font-family:"Calibri", sans-serif" class="font"><span style="font-size:11pt" class="size"><span lang="EN-US"><span></span></span></span></span><br></p><p style="margin: 0cm 0cm 8pt; line-height: 107%;" class="qt-MsoNormal"><span style="font-family:"Calibri", sans-serif" class="font"><span style="font-size:11pt" class="size"><span lang="EN-US"><span>Thank you in advance</span></span></span></span><br></p><p style="margin: 0cm 0cm 8pt; line-height: 107%;" class="qt-MsoNormal"><span style="font-family:"Calibri", sans-serif" class="font"><span style="font-size:11pt" class="size"><span lang="EN-US"><span>Best regards</span></span></span></span><br></p><p style="margin: 0cm 0cm 8pt; line-height: 107%;" class="qt-MsoNormal"><span style="font-family:"Calibri", sans-serif" class="font"><span style="font-size:11pt" class="size"><span lang="EN-US"><span></span></span></span></span><br></p><p style="margin: 0cm 0cm 8pt; line-height: 107%;" class="qt-MsoNormal"><span style="font-family:"Calibri", sans-serif" class="font"><span style="font-size:11pt" class="size"><span lang="EN-US"><span>Farid</span></span></span></span><br></p><p style="margin: 0cm 0cm 8pt; line-height: 107%;" class="qt-MsoNormal"><span style="font-family:"Calibri", sans-serif" class="font"><span style="font-size:11pt" class="size"><span lang="EN-US"><span></span></span></span></span><br></p></div><div><br></div><div class="qt-gmail_quote"><div class="qt-gmail_attr" dir="ltr">On Wed, Jan 8, 2020 at 9:23 PM Farid Hammane <<a href="mailto:farid.hammane@gmail.com">farid.hammane@gmail.com</a>> wrote:<br></div><blockquote style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="qt-gmail_quote"><div>The variable 'rate' in aout_sys_t had 18bits, which was<br></div><div> not enough to represent values greater than 262143.<br></div><div> <br></div><div> This patch increases the number of bits reserved for<br></div><div> the sample rate while keeping enough bits for 'channels'<br></div><div> to be able to represent up to 1023;<br></div><div> <br></div><div> This patch also fixes an inconsistency in the number<br></div><div> of supported channels. According to source code, where<br></div><div> channel mapping is configured, amem only supports 8<br></div><div> channels.<br></div><div> <br></div><div> Signed-off-by: Farid Hammane <<a href="mailto:farid.hammane@gmail.com">farid.hammane@gmail.com</a>><br></div><div> ---<br></div><div> modules/audio_output/amem.c | 9 +++++----<br></div><div> 1 file changed, 5 insertions(+), 4 deletions(-)<br></div><div> <br></div><div> diff --git a/modules/audio_output/amem.c b/modules/audio_output/amem.c<br></div><div> index 0e10a86211..f89b5ec4fe 100644<br></div><div> --- a/modules/audio_output/amem.c<br></div><div> +++ b/modules/audio_output/amem.c<br></div><div> @@ -31,6 +31,7 @@ static int Open (vlc_object_t *);<br></div><div> static void Close (vlc_object_t *);<br></div><div> <br></div><div> #define AMEM_SAMPLE_RATE_MAX 384000<br></div><div> +#define AMEM_CHAN_MAX 8<br></div><div> <br></div><div> vlc_module_begin ()<br></div><div> set_shortname (N_("Audio memory"))<br></div><div> @@ -49,7 +50,7 @@ vlc_module_begin ()<br></div><div> change_private()<br></div><div> add_integer ("amem-channels", 2,<br></div><div> N_("Channels count"), N_("Channels count"), false)<br></div><div> - change_integer_range (1, AOUT_CHAN_MAX)<br></div><div> + change_integer_range (1, AMEM_CHAN_MAX)<br></div><div> change_private()<br></div><div> <br></div><div> vlc_module_end ()<br></div><div> @@ -67,8 +68,8 @@ typedef struct<br></div><div> };<br></div><div> struct<br></div><div> {<br></div><div> - unsigned rate:18;<br></div><div> - unsigned channels:14;<br></div><div> + unsigned rate:22;<br></div><div> + unsigned channels:10;<br></div><div> };<br></div><div> };<br></div><div> void (*play) (void *opaque, const void *data, unsigned count, int64_t pts);<br></div><div> @@ -229,7 +230,7 @@ static int Start (audio_output_t *aout, audio_sample_format_t *fmt)<br></div><div> <br></div><div> /* Ensure that format is supported */<br></div><div> if (fmt->i_rate == 0 || fmt->i_rate > AMEM_SAMPLE_RATE_MAX<br></div><div> - || channels == 0 || channels > AOUT_CHAN_MAX<br></div><div> + || channels == 0 || channels > AMEM_CHAN_MAX<br></div><div> || strcmp(format, "S16N") /* TODO: amem-format */)<br></div><div> {<br></div><div> msg_Err (aout, "format not supported: %s, %u channel(s), %u Hz",<br></div><div> -- <br></div><div> 2.20.1<br></div><div> <br></div></blockquote></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></body></html>