<!DOCTYPE html><html><head><title></title><style type="text/css">
p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div>Hello,<br></div><div><br></div><div>I checked the code, I don't think there is a real use of specifying rate and channels size.<br></div><div>Maybe I missed something obvious but why not just remove the size specifier like the following :<br></div><div><br></div><div> union<br></div><div> {<br></div><div> struct<br></div><div> {<br></div><div> void *setup_opaque;<br></div><div> };<br></div><div> struct<br></div><div> {<br></div><div> unsigned rate;<br></div><div> unsigned channels;<br></div><div> };<br></div><div> };<br></div><div><br></div><div>On Wed, Jan 8, 2020, at 11:47, Jean-Baptiste Kempf wrote:<br></div><blockquote type="cite" id="qt"><div>I do not know, but usually s16n, fl32 are the main ones. fl64 I do not know the use, tbh.<br></div><div><br></div><div>On Wed, Jan 8, 2020, at 11:29, Farid HAMMANE wrote:<br></div><blockquote id="qt-qt" type="cite"><div dir="ltr"><div>Hello Jean-Baptiste,<br></div><div><br></div><div><span class="qt-qt-gmail-tlid-translation qt-qt-gmail-translation" lang="en"><span title="" class="qt-qt-gmail-">Thank you for your suggestion.</span> <span title="" class="qt-qt-gmail-">Yesterday I sent a new patch taking into account your suggestion.</span></span><br></div><div><br></div><div>My next patch in amem will be the support of different formats. <br></div><div>I have identified some of them and I would like to ask you if you have any needs or suggestions ?<br></div><div><br></div><div>The formats already identified are: s16n, s24n, s32n, fl32, fl64.<br></div><div><br></div><div>Thank you in advance for your response<br></div><div><br></div><div>Best regards<br></div><div>Farid<br></div></div><div><br></div><div class="qt-qt-gmail_quote"><div dir="ltr" class="qt-qt-gmail_attr">On Tue, Jan 7, 2020 at 11:00 AM Jean-Baptiste Kempf <<a href="mailto:jb@videolan.org">jb@videolan.org</a>> wrote:<br></div><blockquote class="qt-qt-gmail_quote" style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div><u></u><br></div><div><div>Hello,<br></div><div><br></div><div>It is just that we currently have samples with 18 channels and some with ambisonic HOA 3rd channel (16channels).<br></div><div>Object-based will grow to 64 channels.<br></div><div><br></div><div>I would suggest to cut with channels at 10 and the rest for the rate.<br></div><div><br></div><div>best,<br></div><div><br></div><div>On Tue, Jan 7, 2020, at 09:12, Farid HAMMANE wrote:<br></div><blockquote type="cite" id="qt-qt-gmail-m_-7329055869566801123qt"><div dir="ltr"><div>Hello Jean-Basptite,<br></div><div><br></div><div>Thank you for your review.<br></div><div><br></div><div>I agree that the number of channels grows in audio<br></div><div>systems. If there is no other reason except to save<br></div><div>space by sharing 32bits, I can declare them<br></div><div>as in audio_sample_format_t, i.e. an unsigned int<br></div><div>for the frequency and an uint16_t for the number of<br></div><div>channels. Is it ok for you ?<br></div><div><br></div><div>Note that as I wrote in the commit message, amem<br></div><div>currently does not support more than 8 channels<br></div><div><br></div><div>Best regards<br></div><div>Farid<br></div></div><div><br></div><div><div dir="ltr">On Tue, Jan 7, 2020 at 1:14 AM Jean-Baptiste Kempf <<a href="mailto:jb@videolan.org">jb@videolan.org</a>> wrote:<br></div><blockquote style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div>Hello,<br></div><div><br></div><div>On Tue, Jan 7, 2020, at 01:10, Farid Hammane wrote:<br></div><div>> Today, the maximum value allowed for the sample rate<br></div><div>> is 384000. 19 bits would be enough. The maximum value<br></div><div>> allowed for the number of channels is 8. 4 bits are enough.<br></div><div><br></div><div>We currently support more than 8 channels in the core.<br></div><div>Planning for 16 seems a minimum, IMHO.<br></div><div><br></div><div><br></div><div>-- <br></div><div>Jean-Baptiste Kempf - President<br></div><div>+33 672 704 734<br></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a rel="noreferrer" href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote><div><br></div><div id="qt-qt-gmail-m_-7329055869566801123sig60240713"><div>--<br></div><div>Jean-Baptiste Kempf - President<br></div><div>+33 672 704 734<br></div><div> <br></div><div><br></div></div><div><br></div></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div><div id="qt-sig60240713"><div class="qt-signature">--<br></div><div class="qt-signature">Jean-Baptiste Kempf - President<br></div><div class="qt-signature">+33 672 704 734<br></div><div class="qt-signature"> <br></div><div class="qt-signature"><br></div></div><div><br></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></body></html>